From: Heng Qi <hengqi@linux.alibaba.com>
To: netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: Jason Wang <jasowang@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [PATCH v2 1/9] virtio_net: disable the hole mechanism for xdp
Date: Tue, 20 Dec 2022 22:14:41 +0800 [thread overview]
Message-ID: <20221220141449.115918-2-hengqi@linux.alibaba.com> (raw)
In-Reply-To: <20221220141449.115918-1-hengqi@linux.alibaba.com>
XDP core assumes that the frame_size of xdp_buff and the length of
the frag are PAGE_SIZE. The hole may cause the processing of xdp to
fail, so we disable the hole mechanism when xdp is set.
Signed-off-by: Heng Qi <hengqi@linux.alibaba.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
---
drivers/net/virtio_net.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 9cce7dec7366..443aa7b8f0ad 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1419,8 +1419,11 @@ static int add_recvbuf_mergeable(struct virtnet_info *vi,
/* To avoid internal fragmentation, if there is very likely not
* enough space for another buffer, add the remaining space to
* the current buffer.
+ * XDP core assumes that frame_size of xdp_buff and the length
+ * of the frag are PAGE_SIZE, so we disable the hole mechanism.
*/
- len += hole;
+ if (!headroom)
+ len += hole;
alloc_frag->offset += hole;
}
--
2.19.1.6.gb485710b
next prev parent reply other threads:[~2022-12-20 14:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 14:14 [PATCH v2 0/9] virtio_net: support multi buffer xdp Heng Qi
2022-12-20 14:14 ` Heng Qi [this message]
2022-12-27 6:30 ` [PATCH v2 1/9] virtio_net: disable the hole mechanism for xdp Jason Wang
2022-12-27 7:32 ` Heng Qi
2022-12-28 6:28 ` Jason Wang
2022-12-28 8:24 ` Heng Qi
2022-12-20 14:14 ` [PATCH v2 2/9] virtio_net: set up xdp for multi buffer packets Heng Qi
2022-12-27 6:32 ` Jason Wang
2022-12-27 12:20 ` Heng Qi
2022-12-28 3:50 ` Heng Qi
2022-12-28 6:27 ` Jason Wang
2022-12-20 14:14 ` [PATCH v2 3/9] virtio_net: update bytes calculation for xdp_frame Heng Qi
2022-12-20 14:14 ` [PATCH v2 4/9] virtio_net: build xdp_buff with multi buffers Heng Qi
2022-12-27 6:46 ` Jason Wang
2022-12-27 9:10 ` Heng Qi
2022-12-28 6:27 ` Jason Wang
2022-12-28 8:17 ` Heng Qi
2022-12-20 14:14 ` [PATCH v2 5/9] virtio_net: construct multi-buffer xdp in mergeable Heng Qi
2022-12-27 7:01 ` Jason Wang
2022-12-27 9:31 ` Heng Qi
2022-12-28 6:24 ` Jason Wang
2022-12-28 8:23 ` Heng Qi
2022-12-28 11:54 ` Jason Wang
2022-12-20 14:14 ` [PATCH v2 6/9] virtio_net: transmit the multi-buffer xdp Heng Qi
2022-12-27 7:12 ` Jason Wang
2022-12-27 8:26 ` Heng Qi
2022-12-28 6:30 ` Jason Wang
2022-12-28 8:25 ` Heng Qi
2022-12-20 14:14 ` [PATCH v2 7/9] virtio_net: build skb from " Heng Qi
2022-12-27 7:31 ` Jason Wang
2022-12-27 7:51 ` Heng Qi
2022-12-20 14:14 ` [PATCH v2 8/9] virtio_net: remove xdp related info from page_to_skb() Heng Qi
2022-12-27 7:55 ` Jason Wang
2022-12-27 8:27 ` Heng Qi
2022-12-20 14:14 ` [PATCH v2 9/9] virtio_net: support multi-buffer xdp Heng Qi
2022-12-27 9:03 ` Jason Wang
2022-12-27 9:11 ` Heng Qi
2022-12-22 1:30 ` [PATCH v2 0/9] virtio_net: support multi buffer xdp Jakub Kicinski
2022-12-22 2:04 ` Heng Qi
2022-12-26 2:32 ` Heng Qi
2022-12-26 4:14 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220141449.115918-2-hengqi@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox