From: Namhyung Kim <namhyung@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
bpf@vger.kernel.org
Subject: [PATCH 3/3] perf/core: Save calculated sample data size
Date: Thu, 29 Dec 2022 12:41:01 -0800 [thread overview]
Message-ID: <20221229204101.1099430-3-namhyung@kernel.org> (raw)
In-Reply-To: <20221229204101.1099430-1-namhyung@kernel.org>
To avoid duplicate work in perf_prepare_sample(), save the final header
size in data->saved_size. It's initialized to 0 and set to an actual
value at the end of perf_prepare_sample().
If it sees a non-zero value that means it's the second time of the call
and it knows the sample data is populated already. So update the header
size with the data->saved_size and bail out.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
include/linux/perf_event.h | 2 ++
kernel/events/core.c | 11 +++++++++++
2 files changed, 13 insertions(+)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index dd565306f479..ccde631a0cb4 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -1103,6 +1103,7 @@ struct perf_sample_data {
*/
u64 sample_flags;
u64 period;
+ u64 saved_size;
/*
* Fields commonly set by __perf_event_header__init_id(),
@@ -1158,6 +1159,7 @@ static inline void perf_sample_data_init(struct perf_sample_data *data,
/* remaining struct members initialized in perf_prepare_sample() */
data->sample_flags = PERF_SAMPLE_PERIOD;
data->period = period;
+ data->saved_size = 0;
if (addr) {
data->addr = addr;
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 70bff8a04583..dac4d76e2877 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -7575,6 +7575,15 @@ void perf_prepare_sample(struct perf_event_header *header,
header->misc = 0;
header->misc |= perf_misc_flags(regs);
+ /*
+ * If it called perf_prepare_sample() already, it set the all data fields
+ * and recorded the final size to data->saved_size.
+ */
+ if (data->saved_size) {
+ header->size = data->saved_size;
+ return;
+ }
+
/*
* Clear the sample flags that have already been done by the
* PMU driver.
@@ -7796,6 +7805,8 @@ void perf_prepare_sample(struct perf_event_header *header,
* do here next.
*/
WARN_ON_ONCE(header->size & 7);
+
+ data->saved_size = header->size;
}
static __always_inline int
--
2.39.0.314.g84b9a713c41-goog
prev parent reply other threads:[~2022-12-29 20:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 20:40 [PATCH 1/3] perf/core: Change the layout of perf_sample_data Namhyung Kim
2022-12-29 20:41 ` [PATCH 2/3] perf/core: Set data->sample_flags in perf_prepare_sample() Namhyung Kim
2023-01-09 12:14 ` Peter Zijlstra
2023-01-09 20:21 ` Namhyung Kim
2023-01-10 10:54 ` Peter Zijlstra
2023-01-10 11:10 ` Ingo Molnar
2023-01-10 19:00 ` Namhyung Kim
2023-01-10 10:55 ` Peter Zijlstra
2023-01-10 19:01 ` Namhyung Kim
2023-01-10 20:06 ` Namhyung Kim
2023-01-11 12:54 ` Peter Zijlstra
2023-01-11 16:45 ` Peter Zijlstra
2023-01-11 17:59 ` Namhyung Kim
2022-12-29 20:41 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221229204101.1099430-3-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox