From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Martin KaFai Lau <martin.lau@linux.dev>,
netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, davem@davemloft.net, hawk@kernel.org,
pabeni@redhat.com, edumazet@google.com, toke@redhat.com,
memxor@gmail.com, alardam@gmail.com, saeedm@nvidia.com,
anthony.l.nguyen@intel.com, gospo@broadcom.com,
vladimir.oltean@nxp.com, nbd@nbd.name, john@phrozen.org,
leon@kernel.org, simon.horman@corigine.com, aelior@marvell.com,
christophe.jaillet@wanadoo.fr, ecree.xilinx@gmail.com,
mst@redhat.com, bjorn@kernel.org, magnus.karlsson@intel.com,
maciej.fijalkowski@intel.com, intel-wired-lan@lists.osuosl.org,
lorenzo.bianconi@redhat.com, niklas.soderlund@corigine.com,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 6/7] bpf: devmap: check XDP features in bpf_map_update_elem and __xdp_enqueue
Date: Mon, 23 Jan 2023 12:09:58 -0800 [thread overview]
Message-ID: <20230123120958.741cf5f1@kernel.org> (raw)
In-Reply-To: <Y80odbX/CVjlYalh@lore-desk>
On Sun, 22 Jan 2023 13:13:41 +0100 Lorenzo Bianconi wrote:
> > > diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
> > > index d01e4c55b376..69ceecc792df 100644
> > > --- a/kernel/bpf/devmap.c
> > > +++ b/kernel/bpf/devmap.c
> > > @@ -474,7 +474,11 @@ static inline int __xdp_enqueue(struct net_device *dev, struct xdp_frame *xdpf,
> > > {
> > > int err;
> > > - if (!dev->netdev_ops->ndo_xdp_xmit)
> > > + if (!(dev->xdp_features & NETDEV_XDP_ACT_NDO_XMIT))
> >
> > The current "dev->netdev_ops->ndo_xdp_xmit" check is self explaining.
> > Any plan to put some document for the NETDEV_XDP_ACT_* values?
> >
>
> I am not a yaml description expert but I guess we can xdp features description
> in Documentation/netlink/specs/netdev.yaml.
>
> @Jakub: what do you think?
I've added the ability to document enums recently, so you may need
to rebase. But it should work and render the documentation as kdoc
in the uAPI header (hopefully in a not-too-ugly way).
Example of YAML:
https://github.com/kuba-moo/ynl/blob/dpll/Documentation/netlink/specs/dpll.yaml#L27-L46
I've also talked to the iproute2-py maintainer about generating
documentation directly from YAML to Sphinx/htmldocs, hopefully
that will happen, too. It would be good to have a few families
to work with before we start that work, tho.
next prev parent reply other threads:[~2023-01-23 20:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 17:16 [PATCH bpf-next 0/7] xdp: introduce xdp-feature support Lorenzo Bianconi
2023-01-20 17:16 ` [PATCH bpf-next 1/7] netdev-genl: create a simple family for netdev stuff Lorenzo Bianconi
2023-01-21 1:19 ` Alexei Starovoitov
2023-01-22 17:45 ` Lorenzo Bianconi
2023-01-21 3:11 ` Jakub Kicinski
2023-01-22 23:00 ` Lorenzo Bianconi
2023-01-23 20:01 ` Jakub Kicinski
2023-01-23 23:29 ` Lorenzo Bianconi
2023-01-21 4:42 ` kernel test robot
2023-01-20 17:16 ` [PATCH bpf-next 2/7] drivers: net: turn on XDP features Lorenzo Bianconi
2023-01-21 3:11 ` Jakub Kicinski
2023-01-22 11:49 ` Lorenzo Bianconi
2023-01-23 20:03 ` Jakub Kicinski
2023-01-20 17:16 ` [PATCH bpf-next 3/7] xsk: add usage of XDP features flags Lorenzo Bianconi
2023-01-20 17:16 ` [PATCH bpf-next 4/7] libbpf: add the capability to specify netlink proto in libbpf_netlink_send_recv Lorenzo Bianconi
2023-01-20 17:16 ` [PATCH bpf-next 5/7] libbpf: add API to get XDP/XSK supported features Lorenzo Bianconi
2023-01-21 3:20 ` Jakub Kicinski
2023-01-22 12:09 ` Lorenzo Bianconi
2023-01-20 17:16 ` [PATCH bpf-next 6/7] bpf: devmap: check XDP features in bpf_map_update_elem and __xdp_enqueue Lorenzo Bianconi
2023-01-21 2:02 ` Martin KaFai Lau
2023-01-22 12:13 ` Lorenzo Bianconi
2023-01-23 20:09 ` Jakub Kicinski [this message]
2023-01-23 23:29 ` Lorenzo Bianconi
2023-01-20 17:16 ` [PATCH bpf-next 7/7] selftests/bpf: introduce XDP compliance test tool Lorenzo Bianconi
2023-01-24 6:34 ` Martin KaFai Lau
2023-01-24 11:12 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123120958.741cf5f1@kernel.org \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=alardam@gmail.com \
--cc=andrii@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john@phrozen.org \
--cc=leon@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mst@redhat.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@corigine.com \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=toke@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).