Re: [PATCH bpf-next v2 3/3] bpf: Use BPF_KFUNC macro at all kfunc definitions

Jonathan Corbet
2023-01-23T21:01:02Z

Daniel Borkmann <daniel@iogearbox.net> writes:

> Did you look into making this similar to the EXPORT_SYMBOL() infra? If possible
> that would look much more natural to developers, e.g. :
>
> struct nf_conn *
> bpf_skb_ct_lookup(struct __sk_buff *skb_ctx, struct bpf_sock_tuple *bpf_tuple,
> u32 tuple__sz, struct bpf_ct_opts *opts, u32 opts__sz)
> {
> [...]
> }
>
> EXPORT_BPF_KFUNC(bpf_skb_ct_lookup);

That was my question too; it's a similar functionality that would be
nice to express in a similar way. Even better, if possible, might be to
fold it into BTF_ID_FLAGS, which I might then rename to EXPORT_KFUNC()
or some such ... :)

Thanks,

jon