From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D1E2C61DA4 for ; Thu, 2 Feb 2023 10:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230246AbjBBK5u (ORCPT ); Thu, 2 Feb 2023 05:57:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbjBBK5t (ORCPT ); Thu, 2 Feb 2023 05:57:49 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5766A191 for ; Thu, 2 Feb 2023 02:57:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675335426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nLgisAhVhjxaFOYw08tk2NZkXdHAeHPvk91YSYHYTNo=; b=W29bVnF9nIRsBC4C0eECS/EYKXKvBDL9SIZ6IGx7F2hFo2DOwsDGBhbBUaXhU+hAi3aWCw Q/m9A45WwImHvH8z/f5BUViEVbxcC7vMlQk2Fa/+ai/hT5uz/1YgyN0i9QW59mdDASZ/XW nO5/kiksBatPcHcENTUlGflMkafct3s= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-357--1JS4x3aOZaNaqEkQAFAaA-1; Thu, 02 Feb 2023 05:57:05 -0500 X-MC-Unique: -1JS4x3aOZaNaqEkQAFAaA-1 Received: by mail-wm1-f72.google.com with SMTP id l5-20020a1ced05000000b003db300f2e1cso778747wmh.0 for ; Thu, 02 Feb 2023 02:57:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nLgisAhVhjxaFOYw08tk2NZkXdHAeHPvk91YSYHYTNo=; b=5QqLzegkC5XZZ68M/pHsuFs4fQlABGBAOplMgl1VAwNx80QrX/W76ZfyUnc6wd67HG 2zeaHOegI8HwpRdJOa3/WsCfNG+dC4kFx3MFc0B/8H4sVILT3tUa17BjHrRuuC9lLfX3 I+IOtZ6SSrHIRDGYzMjcc5NX8op7WfjMQA0/GF5MGuTsARaoK1ER33Oc5Q5gYdRgw8Rj 92gwdavWwVmZY2+klTi1CrYuBTKMj+XCnfH6s+hGSiBUz9GX3wN8TZmh/QaUGdAYFuFs lAUpvtBoIQpFDNMkp5nEKomBm3brhMtd74jrnRS9ZpupuXHium2cUPewTKkrLLMHUoO6 5/2Q== X-Gm-Message-State: AO0yUKUQIdtLH8OxSM1OzC7bWuqkaVercN78cTJ5GetVqFgG/q4f5cPw RFlte96u7LlT1s644I1CTKfKWYGOBQMlIcTEoR5+o0z5ZSiASwDy26saAcamFaAp/ASWRMfr/X4 Vn2f6AMISoSiy X-Received: by 2002:a05:600c:3b0c:b0:3d2:813:138a with SMTP id m12-20020a05600c3b0c00b003d20813138amr1515647wms.35.1675335424010; Thu, 02 Feb 2023 02:57:04 -0800 (PST) X-Google-Smtp-Source: AK7set/psrnYQSpicehicPlykAuaLwGGouzJxfU7GSH68r+uUKziLdcFHTfe7pPMuUCzZZ/UZoUzFw== X-Received: by 2002:a05:600c:3b0c:b0:3d2:813:138a with SMTP id m12-20020a05600c3b0c00b003d20813138amr1515635wms.35.1675335423854; Thu, 02 Feb 2023 02:57:03 -0800 (PST) Received: from redhat.com ([2a02:14f:1fc:826d:55d8:70a4:3d30:fc2f]) by smtp.gmail.com with ESMTPSA id j25-20020a05600c1c1900b003daf6e3bc2fsm6888625wms.1.2023.02.02.02.56.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 02:57:03 -0800 (PST) Date: Thu, 2 Feb 2023 05:56:57 -0500 From: "Michael S. Tsirkin" To: Parav Pandit Cc: jasowang@redhat.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, virtualization@lists.linux-foundation.org, bpf@vger.kernel.org Subject: Re: [PATCH 0/2] virtio-net: close() to follow mirror of open() Message-ID: <20230202055630-mutt-send-email-mst@kernel.org> References: <20230202050038.3187-1-parav@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202050038.3187-1-parav@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Feb 02, 2023 at 07:00:36AM +0200, Parav Pandit wrote: > Hi, > > This two small patches improves ndo_close() callback to follow > the mirror sequence of ndo_open() callback. This improves the code auditing > and also ensure that xdp rxq info is not unregistered while NAPI on > RXQ is ongoing. Acked-by: Michael S. Tsirkin I'm guessing -net and 1/2 for stable? > Please review. > > Patch summary: > patch-1 ensures that xdp rq info is unregistered after rq napi is disabled > patch-2 keeps the mirror sequence for close() be mirror of open() > > Parav Pandit (2): > virtio-net: Keep stop() to follow mirror sequence of open() > virtio-net: Maintain reverse cleanup order > > drivers/net/virtio_net.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > -- > 2.26.2