From: Jon Doron <arilou@gmail.com>
To: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org
Cc: Jon Doron <jond@wiz.io>
Subject: [PATCH bpf-next v2] libbpf: Add wakeup_events to creation options
Date: Thu, 2 Feb 2023 08:25:49 +0200 [thread overview]
Message-ID: <20230202062549.632425-1-arilou@gmail.com> (raw)
From: Jon Doron <jond@wiz.io>
Add option to set when the perf buffer should wake up, by default the
perf buffer becomes signaled for every event that is being pushed to it.
In case of a high throughput of events it will be more efficient to wake
up only once you have X events ready to be read.
So your application can wakeup once and drain the entire perf buffer.
Signed-off-by: Jon Doron <jond@wiz.io>
---
tools/lib/bpf/libbpf.c | 4 ++--
tools/lib/bpf/libbpf.h | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index eed5cec6f510..6b30ff13922b 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -11719,8 +11719,8 @@ struct perf_buffer *perf_buffer__new(int map_fd, size_t page_cnt,
attr.config = PERF_COUNT_SW_BPF_OUTPUT;
attr.type = PERF_TYPE_SOFTWARE;
attr.sample_type = PERF_SAMPLE_RAW;
- attr.sample_period = 1;
- attr.wakeup_events = 1;
+ attr.sample_period = OPTS_GET(opts, wakeup_events, 1);
+ attr.wakeup_events = OPTS_GET(opts, wakeup_events, 1);
p.attr = &attr;
p.sample_cb = sample_cb;
diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h
index 8777ff21ea1d..e83c0a915dc7 100644
--- a/tools/lib/bpf/libbpf.h
+++ b/tools/lib/bpf/libbpf.h
@@ -1246,8 +1246,9 @@ typedef void (*perf_buffer_lost_fn)(void *ctx, int cpu, __u64 cnt);
/* common use perf buffer options */
struct perf_buffer_opts {
size_t sz;
+ __u32 wakeup_events;
};
-#define perf_buffer_opts__last_field sz
+#define perf_buffer_opts__last_field wakeup_events
/**
* @brief **perf_buffer__new()** creates BPF perfbuf manager for a specified
--
2.39.1
next reply other threads:[~2023-02-02 6:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 6:25 Jon Doron [this message]
2023-02-02 22:50 ` [PATCH bpf-next v2] libbpf: Add wakeup_events to creation options Andrii Nakryiko
2023-02-03 7:14 ` Jon Doron
2023-02-03 21:41 ` Andrii Nakryiko
2023-02-03 18:31 ` Yonghong Song
2023-02-03 21:42 ` Andrii Nakryiko
2023-02-03 23:11 ` Yonghong Song
2023-02-06 5:39 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230202062549.632425-1-arilou@gmail.com \
--to=arilou@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jond@wiz.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox