From: Vladimir Oltean <olteanv@gmail.com>
To: Jiri Olsa <olsajiri@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Ian Rogers <irogers@google.com>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Connor OBrien <connoro@google.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] tools/resolve_btfids: Tidy host CFLAGS forcing
Date: Fri, 3 Feb 2023 20:41:25 +0200 [thread overview]
Message-ID: <20230203184125.2ka4cor4pefs3337@skbuf> (raw)
In-Reply-To: <Y9ufUdzOSp9y9qQA@krava>
Hi,
On Thu, Feb 02, 2023 at 12:32:33PM +0100, Jiri Olsa wrote:
> On Wed, Feb 01, 2023 at 02:21:16PM -0700, Nathan Chancellor wrote:
>
> SNIP
>
> > > > Should we do this and the hostprogs migration as a follow up? There
> > > > isn't that much use of hostprogs in tools, but I like that your change
> > > > will show HOSTCC rather than CC during compilation. If we use
> > > > hostprogs can we just avoid the overrides altogether?
> > >
> > > right, I think so.. we can now remove it for the BINARY target and
> > > then for the rest of 'prepare' once they are converted to hostprogs..
> > > not sure how 'hostprogs' will work for library, will need to check
> > >
> > > I'll try to send the format patch with the fix below tomorrow
> > >
> > > Nathan, any chance you could test it?
> >
> >
> > Sure thing, would you happen to have a single patch file of what I
> > should test? I am a little confused from reading the thread (unless what
> > you want tested has not been sent yet).
>
> I meant the change below, but I posted the formal patch now:
> https://lore.kernel.org/bpf/20230202112839.1131892-1-jolsa@kernel.org/T/#u
I've been chasing the links posted by Ian, but now I can't comment on patch
"tools/resolve_btfids: Compile resolve_btfids as host program", because
lkml wasn't CCed, and I'm not subscribed to the bpf ML. So I'm commenting here.
Can someone please apply the patch linked above? Compiling with
CONFIG_DEBUG_INFO_BTF=y is also broken on net-next.
Maintainers can add my
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
on that patch if it helps speed up the process.
prev parent reply other threads:[~2023-02-03 18:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 1:50 [PATCH v1] tools/resolve_btfids: Tidy host CFLAGS forcing Ian Rogers
2023-02-01 9:59 ` Jiri Olsa
2023-02-01 10:43 ` Jiri Olsa
2023-02-01 18:57 ` Ian Rogers
2023-02-01 20:50 ` Jiri Olsa
2023-02-01 21:21 ` Nathan Chancellor
2023-02-01 21:42 ` Ian Rogers
2023-02-02 11:32 ` Jiri Olsa
2023-02-03 18:41 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203184125.2ka4cor4pefs3337@skbuf \
--to=olteanv@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=connoro@google.com \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=nathan@kernel.org \
--cc=olsajiri@gmail.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox