Re: [PATCH bpf-next 4/4] selftests/bpf: Add bpf_fib_lookup test

Martin KaFai Lau
2023-02-17T23:08:41Z

On 2/17/23 3:02 PM, Andrii Nakryiko wrote:
>> +#define SYS(fmt, ...) \
>> + ({ \
>> + char cmd[1024]; \
>> + snprintf(cmd, sizeof(cmd), fmt, ##__VA_ARGS__); \
>> + if (!ASSERT_OK(system(cmd), cmd)) \
>> + goto fail; \
>> + })
>
> it's probably a high time to move this SYS() macro into test_progs.h
> and stop copy/pasting it across many test?

Make sense. will follow up.