From: Jakub Kicinski <kuba@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Kees Cook <kees@kernel.org>,
linux-hardening@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: splat in ikheaders_read (bpftrace)
Date: Thu, 2 Mar 2023 14:41:40 -0800 [thread overview]
Message-ID: <20230302144140.7a1ca7d3@kernel.org> (raw)
In-Reply-To: <64012596.170a0220.1940.0a34@mx.google.com>
On Thu, 2 Mar 2023 14:39:17 -0800 Kees Cook wrote:
> I've improved the reporting, and yeah, it's due to the declaration:
>
> memcpy: detected buffer overflow: 4096 byte read from buffer of size 1
>
> But that's an easy fix -- this has been done in lots of other places. It
> needs to be an array, not a single char. (I'm surprised we hadn't seen
> this before.)
LGTM, feel free to add my Tested-by, if that matters :)
Thanks!
prev parent reply other threads:[~2023-03-02 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 19:21 splat in ikheaders_read (bpftrace) Jakub Kicinski
2023-03-02 21:57 ` Kees Cook
2023-03-02 22:08 ` Jakub Kicinski
2023-03-02 22:12 ` Jakub Kicinski
2023-03-02 22:35 ` Jakub Kicinski
2023-03-02 22:39 ` Kees Cook
2023-03-02 22:41 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302144140.7a1ca7d3@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kees@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox