From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54DBDC6FA99 for ; Tue, 7 Mar 2023 23:27:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbjCGX1c (ORCPT ); Tue, 7 Mar 2023 18:27:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229886AbjCGX1a (ORCPT ); Tue, 7 Mar 2023 18:27:30 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93A83A83B9 for ; Tue, 7 Mar 2023 15:27:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678231648; x=1709767648; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cFQK4yoJNwJ2MYUgHEj7uj88LU7UNUl/bdTmD3rdioU=; b=JwIdwBUA1oRFgEUwfHXEyE2cq5UsuQ0mKY+S77AFkoDtkGunYTmMewxX JF7uCDOlLYr4IEqjOpL5jQcO4jyOqZU9Ix4OQt1VcjXSDQe7x1siZMFuV vYZvHiclvNMXLOLIDnz+hs3QjPhb9URtYYosGKNJihD3R9YcctI92fISw pxcKc/wop5CDJZVo1TBxqLjvE50WvylO1rr8JvSlbG+Ltxgho7skhBRJi AL2ZnoamSOgLzNMS1RLhV6qxvfgJ07FkqxLRPbLiWKJG9TSBlS0/qVnk2 CrE116MWZK2lCd3A1CauYEugxeob0fOqCShqPhC6ijHv3ufvZXuooBww+ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="422272303" X-IronPort-AV: E=Sophos;i="5.98,242,1673942400"; d="scan'208";a="422272303" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2023 15:27:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="786880360" X-IronPort-AV: E=Sophos;i="5.98,242,1673942400"; d="scan'208";a="786880360" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 07 Mar 2023 15:27:26 -0800 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pZgiL-0001gN-2l; Tue, 07 Mar 2023 23:27:25 +0000 Date: Wed, 8 Mar 2023 07:26:58 +0800 From: kernel test robot To: Andrii Nakryiko , bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net Cc: oe-kbuild-all@lists.linux.dev, andrii@kernel.org, kernel-team@fb.com, Tejun Heo Subject: Re: [PATCH v2 bpf-next 3/8] bpf: add support for open-coded iterator loops Message-ID: <202303080733.7uzHxIB0-lkp@intel.com> References: <20230307215329.3895377-4-andrii@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230307215329.3895377-4-andrii@kernel.org> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi Andrii, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Andrii-Nakryiko/bpf-factor-out-fetching-basic-kfunc-metadata/20230308-055530 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20230307215329.3895377-4-andrii%40kernel.org patch subject: [PATCH v2 bpf-next 3/8] bpf: add support for open-coded iterator loops config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230308/202303080733.7uzHxIB0-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/9eada50b93c4fc3f41032699fda73bc125b37d0e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andrii-Nakryiko/bpf-factor-out-fetching-basic-kfunc-metadata/20230308-055530 git checkout 9eada50b93c4fc3f41032699fda73bc125b37d0e # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash kernel/bpf/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303080733.7uzHxIB0-lkp@intel.com/ All warnings (new ones prefixed by >>): kernel/bpf/verifier.c: In function 'is_iter_reg_valid_init': >> kernel/bpf/verifier.c:1255:32: warning: variable 't' set but not used [-Wunused-but-set-variable] 1255 | const struct btf_type *t; | ^ vim +/t +1255 kernel/bpf/verifier.c 1250 1251 static bool is_iter_reg_valid_init(struct bpf_verifier_env *env, struct bpf_reg_state *reg, 1252 struct btf *btf, u32 btf_id, int nr_slots) 1253 { 1254 struct bpf_func_state *state = func(env, reg); > 1255 const struct btf_type *t; 1256 int spi, i, j; 1257 1258 spi = iter_get_spi(env, reg, nr_slots); 1259 if (spi < 0) 1260 return false; 1261 1262 t = btf_type_by_id(btf, btf_id); 1263 1264 for (i = 0; i < nr_slots; i++) { 1265 struct bpf_stack_state *slot = &state->stack[spi - i]; 1266 struct bpf_reg_state *st = &slot->spilled_ptr; 1267 1268 /* only main (first) slot has ref_obj_id set */ 1269 if (i == 0 && !st->ref_obj_id) 1270 return false; 1271 if (i != 0 && st->ref_obj_id) 1272 return false; 1273 if (st->iter.btf != btf || st->iter.btf_id != btf_id) 1274 return false; 1275 1276 for (j = 0; j < BPF_REG_SIZE; j++) 1277 if (slot->slot_type[j] != STACK_ITER) 1278 return false; 1279 } 1280 1281 return true; 1282 } 1283 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests