From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC910C77B6C for ; Tue, 28 Mar 2023 23:57:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbjC1X5C convert rfc822-to-8bit (ORCPT ); Tue, 28 Mar 2023 19:57:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbjC1X47 (ORCPT ); Tue, 28 Mar 2023 19:56:59 -0400 Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BB8F30E8 for ; Tue, 28 Mar 2023 16:56:36 -0700 (PDT) Received: from pps.filterd (m0089730.ppops.net [127.0.0.1]) by m0089730.ppops.net (8.17.1.19/8.17.1.19) with ESMTP id 32SJZpbp016933 for ; Tue, 28 Mar 2023 16:56:31 -0700 Received: from mail.thefacebook.com ([163.114.132.120]) by m0089730.ppops.net (PPS) with ESMTPS id 3pkha41b0v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 28 Mar 2023 16:56:31 -0700 Received: from twshared58712.02.prn6.facebook.com (2620:10d:c085:108::4) by mail.thefacebook.com (2620:10d:c085:21d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Tue, 28 Mar 2023 16:56:30 -0700 Received: by devbig019.vll3.facebook.com (Postfix, from userid 137359) id B69DB2C40042D; Tue, 28 Mar 2023 16:56:20 -0700 (PDT) From: Andrii Nakryiko To: , , , , , , CC: , Subject: [PATCH v2 bpf-next 4/6] libbpf: don't enforce verifier log levels on libbpf side Date: Tue, 28 Mar 2023 16:56:07 -0700 Message-ID: <20230328235610.3159943-5-andrii@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230328235610.3159943-1-andrii@kernel.org> References: <20230328235610.3159943-1-andrii@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-ORIG-GUID: iJpFGRqcj3ARfvb5LYEedkdvAHXu_Wnf X-Proofpoint-GUID: iJpFGRqcj3ARfvb5LYEedkdvAHXu_Wnf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_11,2023-03-28_02,2023-02-09_01 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org This basically prevents any forward compatibility. And we either way just return -EINVAL, which would otherwise be returned from bpf() syscall anyways. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/bpf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c index 767035900354..615185226ed0 100644 --- a/tools/lib/bpf/bpf.c +++ b/tools/lib/bpf/bpf.c @@ -290,8 +290,6 @@ int bpf_prog_load(enum bpf_prog_type prog_type, if (!!log_buf != !!log_size) return libbpf_err(-EINVAL); - if (log_level > (4 | 2 | 1)) - return libbpf_err(-EINVAL); if (log_level && !log_buf) return libbpf_err(-EINVAL); -- 2.34.1