From: Kees Cook <keescook@chromium.org>
To: Azeem Shaikh <azeemshaikh38@gmail.com>
Cc: linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Zhen Lei" <thunder.leizhen@huawei.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Alan Maguire" <alan.maguire@oracle.com>,
"Maninder Singh" <maninder1.s@samsung.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Miroslav Benes" <mbenes@suse.cz>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Christian König" <christian.koenig@amd.com>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
bpf@vger.kernel.org
Subject: Re: [PATCH] kallsyms: Replace all non-returning strlcpy with strscpy
Date: Wed, 14 Jun 2023 10:53:22 -0700 [thread overview]
Message-ID: <202306141053.8C337829@keescook> (raw)
In-Reply-To: <20230614010354.1026096-1-azeemshaikh38@gmail.com>
On Wed, Jun 14, 2023 at 01:03:54AM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2023-06-14 17:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 1:03 [PATCH] kallsyms: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-06-14 17:53 ` Kees Cook [this message]
2023-06-14 18:47 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306141053.8C337829@keescook \
--to=keescook@chromium.org \
--cc=alan.maguire@oracle.com \
--cc=azeemshaikh38@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=christian.koenig@amd.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@weissschuh.net \
--cc=maninder1.s@samsung.com \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=peterz@infradead.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox