Re: [PATCH bpf-next v8 1/4] bpf: Add update_socket_protocol hook

[kernel test robot <lkp@intel.com>]

Hi Geliang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Geliang-Tang/bpf-Add-update_socket_protocol-hook/20230803-153209
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/120b307aacd1791fac016d33e112069ffb7db21a.1691047403.git.geliang.tang%40suse.com
patch subject: [PATCH bpf-next v8 1/4] bpf: Add update_socket_protocol hook
config: nios2-randconfig-r006-20230731 (https://download.01.org/0day-ci/archive/20230803/202308032054.aq4D9VOg-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230803/202308032054.aq4D9VOg-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308032054.aq4D9VOg-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/socket.c:1648: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    *      A hook for bpf progs to attach to and update socket protocol.


vim +1648 net/socket.c

  1646	
  1647	/**
> 1648	 *	A hook for bpf progs to attach to and update socket protocol.
  1649	 *
  1650	 *	A static noinline declaration here could cause the compiler to
  1651	 *	optimize away the function. A global noinline declaration will
  1652	 *	keep the definition, but may optimize away the callsite.
  1653	 *	Therefore, __weak is needed to ensure that the call is still
  1654	 *	emitted, by telling the compiler that we don't know what the
  1655	 *	function might eventually be.
  1656	 *
  1657	 *	__diag_* below are needed to dismiss the missing prototype warning.
  1658	 */
  1659	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki