Re: [PATCH 28/29] xfs: support nowait semantics for xc_ctx_lock in xlog_cil_commit()

Dave Chinner
2023-08-25T22:00:06Z

On Fri, Aug 25, 2023 at 09:54:30PM +0800, Hao Xu wrote:
> From: Hao Xu <howeyxu@tencent.com>
>
> Apply trylock logic for xc_ctx_lock in xlog_cil_commit() in nowait
> case and error out -EAGAIN for xlog_cil_commit().

Again, fundamentally broken. Any error from xlog_cil_commit() will
result in a filesystem shutdown as we cannot back out from failure
with dirty log items gracefully at this point.

-Dave.

--
Dave Chinner
david@fromorbit.com