Re: [PATCH 22/29] xfs: comment page allocation for nowait case in xfs_buf_find_insert()

Matthew Wilcox
2023-08-25T14:10:43Z

On Fri, Aug 25, 2023 at 09:54:24PM +0800, Hao Xu wrote:
> @@ -633,6 +633,8 @@ xfs_buf_find_insert(
> * allocate the memory from the heap to minimise memory usage. If we
> * can't get heap memory for these small buffers, we fall back to using
> * the page allocator.
> + * xfs_buf_alloc_kmem may return -EAGAIN, let's not return it but turn
> + * to page allocator as well.

This new sentence seems like it says exactly the same thing as the
previous sentence. What am I missing?