From: kernel test robot <lkp@intel.com>
To: Andrii Nakryiko <andrii@kernel.org>, bpf@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org, keescook@chromium.org,
brauner@kernel.org, lennart@poettering.net, kernel-team@meta.com,
sargun@sargun.me
Subject: Re: [PATCH v4 bpf-next 07/12] bpf: consistenly use BPF token throughout BPF verifier logic
Date: Thu, 14 Sep 2023 06:15:14 +0800 [thread overview]
Message-ID: <202309140537.jHmBqMd6-lkp@intel.com> (raw)
In-Reply-To: <20230912212906.3975866-8-andrii@kernel.org>
Hi Andrii,
kernel test robot noticed the following build errors:
[auto build test ERROR on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Andrii-Nakryiko/bpf-add-BPF-token-delegation-mount-options-to-BPF-FS/20230913-053240
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20230912212906.3975866-8-andrii%40kernel.org
patch subject: [PATCH v4 bpf-next 07/12] bpf: consistenly use BPF token throughout BPF verifier logic
config: x86_64-randconfig-074-20230914 (https://download.01.org/0day-ci/archive/20230914/202309140537.jHmBqMd6-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230914/202309140537.jHmBqMd6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309140537.jHmBqMd6-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/net/sock_reuseport.h:5,
from include/net/tcp.h:35,
from include/linux/netfilter_ipv6.h:11,
from include/uapi/linux/netfilter_ipv6/ip6_tables.h:22,
from include/linux/netfilter_ipv6/ip6_tables.h:23,
from net/ipv6/netfilter/ip6table_filter.c:11:
include/linux/filter.h: In function 'bpf_jit_blinding_enabled':
>> include/linux/filter.h:1104:36: error: implicit declaration of function 'bpf_token_capable'; did you mean 'bpf_token_put'? [-Werror=implicit-function-declaration]
1104 | if (bpf_jit_harden == 1 && bpf_token_capable(prog->aux->token, CAP_BPF))
| ^~~~~~~~~~~~~~~~~
| bpf_token_put
cc1: some warnings being treated as errors
--
In file included from include/net/sock_reuseport.h:5,
from include/net/tcp.h:35,
from include/linux/netfilter_ipv6.h:11,
from net/ipv6/netfilter/nf_reject_ipv6.c:12:
include/linux/filter.h: In function 'bpf_jit_blinding_enabled':
>> include/linux/filter.h:1104:36: error: implicit declaration of function 'bpf_token_capable'; did you mean 'bpf_token_put'? [-Werror=implicit-function-declaration]
1104 | if (bpf_jit_harden == 1 && bpf_token_capable(prog->aux->token, CAP_BPF))
| ^~~~~~~~~~~~~~~~~
| bpf_token_put
net/ipv6/netfilter/nf_reject_ipv6.c: In function 'nf_send_reset6':
net/ipv6/netfilter/nf_reject_ipv6.c:287:25: warning: variable 'ip6h' set but not used [-Wunused-but-set-variable]
287 | struct ipv6hdr *ip6h;
| ^~~~
cc1: some warnings being treated as errors
vim +1104 include/linux/filter.h
1091
1092 static inline bool bpf_jit_blinding_enabled(struct bpf_prog *prog)
1093 {
1094 /* These are the prerequisites, should someone ever have the
1095 * idea to call blinding outside of them, we make sure to
1096 * bail out.
1097 */
1098 if (!bpf_jit_is_ebpf())
1099 return false;
1100 if (!prog->jit_requested)
1101 return false;
1102 if (!bpf_jit_harden)
1103 return false;
> 1104 if (bpf_jit_harden == 1 && bpf_token_capable(prog->aux->token, CAP_BPF))
1105 return false;
1106
1107 return true;
1108 }
1109
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-09-13 22:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 21:28 [PATCH v4 bpf-next 00/12] BPF token and BPF FS-based delegation Andrii Nakryiko
2023-09-12 21:28 ` [PATCH v4 bpf-next 01/12] bpf: add BPF token delegation mount options to BPF FS Andrii Nakryiko
2023-09-12 21:28 ` [PATCH v4 bpf-next 02/12] bpf: introduce BPF token object Andrii Nakryiko
2023-09-12 21:46 ` Andrii Nakryiko
2023-09-13 21:46 ` [PATCH v4 2/12] " Paul Moore
2023-09-14 17:31 ` Andrii Nakryiko
2023-09-15 0:55 ` Paul Moore
2023-09-15 20:59 ` Andrii Nakryiko
2023-09-21 22:18 ` Paul Moore
2023-09-22 9:27 ` Paul Moore
2023-09-22 22:35 ` Andrii Nakryiko
2023-09-26 21:32 ` Paul Moore
2023-10-10 21:19 ` Paul Moore
2023-10-12 0:32 ` Andrii Nakryiko
2023-09-12 21:28 ` [PATCH v4 bpf-next 03/12] bpf: add BPF token support to BPF_MAP_CREATE command Andrii Nakryiko
2023-09-12 21:28 ` [PATCH v4 bpf-next 04/12] bpf: add BPF token support to BPF_BTF_LOAD command Andrii Nakryiko
2023-09-12 21:28 ` [PATCH v4 bpf-next 05/12] bpf: add BPF token support to BPF_PROG_LOAD command Andrii Nakryiko
2023-09-12 21:29 ` [PATCH v4 bpf-next 06/12] bpf: take into account BPF token when fetching helper protos Andrii Nakryiko
2023-09-13 9:45 ` kernel test robot
2023-09-13 18:41 ` kernel test robot
2023-09-12 21:29 ` [PATCH v4 bpf-next 07/12] bpf: consistenly use BPF token throughout BPF verifier logic Andrii Nakryiko
2023-09-13 22:15 ` kernel test robot [this message]
2023-09-12 21:29 ` [PATCH v4 bpf-next 08/12] libbpf: add bpf_token_create() API Andrii Nakryiko
2023-09-12 21:42 ` Andrii Nakryiko
2023-09-12 21:29 ` [PATCH v4 bpf-next 09/12] libbpf: add BPF token support to bpf_map_create() API Andrii Nakryiko
2023-09-12 21:29 ` [PATCH v4 bpf-next 10/12] libbpf: add BPF token support to bpf_btf_load() API Andrii Nakryiko
2023-09-12 21:29 ` [PATCH v4 bpf-next 11/12] libbpf: add BPF token support to bpf_prog_load() API Andrii Nakryiko
2023-09-12 21:29 ` [PATCH v4 bpf-next 12/12] selftests/bpf: add BPF token-enabled tests Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309140537.jHmBqMd6-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=keescook@chromium.org \
--cc=kernel-team@meta.com \
--cc=lennart@poettering.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox