Re: [PATCH bpf-next v2 3/3] bpf: Disable exceptions when CONFIG_UNWINDER_FRAME_POINTER=y

Eric Dumazet
2023-09-18T16:05:15Z

On Mon, Sep 18, 2023 at 5:52 PM Kumar Kartikeya Dwivedi
<memxor@gmail.com> wrote:
>
> The build with CONFIG_UNWINDER_FRAME_POINTER=y is broken for
> current exceptions feature as it assumes ORC unwinder specific fields in
> the unwind_state. Disable exceptions when frame_pointer unwinder is
> enabled for now.
>
> Fixes: fd5d27b70188 ("arch/x86: Implement arch_bpf_stack_walk")
> Reported-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
> ---

SGTM, feel free adding

Reviewed-by: Eric Dumazet <edumazet@google.com>