From: Ian Rogers <irogers@google.com>
To: Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Yang Jihong <yangjihong1@huawei.com>,
Kan Liang <kan.liang@linux.intel.com>,
Ming Wang <wangming01@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Sean Christopherson <seanjc@google.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Yanteng Si <siyanteng@loongson.cn>,
Yuan Can <yuancan@huawei.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
James Clark <james.clark@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
llvm@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, bpf@vger.kernel.org
Subject: [PATCH v1 18/18] perf bpf_counter: Fix a few memory leaks
Date: Fri, 22 Sep 2023 22:35:15 -0700 [thread overview]
Message-ID: <20230923053515.535607-19-irogers@google.com> (raw)
In-Reply-To: <20230923053515.535607-1-irogers@google.com>
Memory leaks were detected by clang-tidy.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/bpf_counter.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/bpf_counter.c b/tools/perf/util/bpf_counter.c
index 6732cbbcf9b3..7f9b0e46e008 100644
--- a/tools/perf/util/bpf_counter.c
+++ b/tools/perf/util/bpf_counter.c
@@ -104,7 +104,7 @@ static int bpf_program_profiler_load_one(struct evsel *evsel, u32 prog_id)
struct bpf_prog_profiler_bpf *skel;
struct bpf_counter *counter;
struct bpf_program *prog;
- char *prog_name;
+ char *prog_name = NULL;
int prog_fd;
int err;
@@ -155,10 +155,12 @@ static int bpf_program_profiler_load_one(struct evsel *evsel, u32 prog_id)
assert(skel != NULL);
counter->skel = skel;
list_add(&counter->list, &evsel->bpf_counter_list);
+ free(prog_name);
close(prog_fd);
return 0;
err_out:
bpf_prog_profiler_bpf__destroy(skel);
+ free(prog_name);
free(counter);
close(prog_fd);
return -1;
@@ -180,6 +182,7 @@ static int bpf_program_profiler__load(struct evsel *evsel, struct target *target
(*p != '\0' && *p != ',')) {
pr_err("Failed to parse bpf prog ids %s\n",
target->bpf_str);
+ free(bpf_str_);
return -1;
}
--
2.42.0.515.g380fc7ccd1-goog
prev parent reply other threads:[~2023-09-23 5:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 5:34 [PATCH v1 00/18] clang-tools support in tools Ian Rogers
2023-09-23 5:34 ` [PATCH v1 01/18] gen_compile_commands: Allow the line prefix to still be cmd_ Ian Rogers
2023-09-25 15:49 ` Nick Desaulniers
2023-09-25 16:06 ` Ian Rogers
2023-09-28 14:23 ` Nicolas Schier
2023-10-03 14:31 ` Masahiro Yamada
2023-10-05 22:35 ` Ian Rogers
2023-09-23 5:34 ` [PATCH v1 02/18] gen_compile_commands: Sort output compile commands by file name Ian Rogers
2023-09-25 15:45 ` Nick Desaulniers
2023-09-23 5:35 ` [PATCH v1 03/18] run-clang-tools: Add pass through checks and and header-filter arguments Ian Rogers
2023-09-25 15:43 ` Nick Desaulniers
2023-10-05 22:38 ` Ian Rogers
2023-09-23 5:35 ` [PATCH v1 04/18] perf hisi-ptt: Fix potential memory leak Ian Rogers
2023-09-23 5:35 ` [PATCH v1 05/18] perf bench uprobe: Fix potential use of memory after free Ian Rogers
2023-09-23 5:35 ` [PATCH v1 06/18] perf buildid-cache: Fix use of uninitialized value Ian Rogers
2023-09-23 5:35 ` [PATCH v1 07/18] perf env: Remove unnecessary NULL tests Ian Rogers
2023-09-23 5:35 ` [PATCH v1 08/18] perf jitdump: Avoid memory leak Ian Rogers
2023-09-23 5:35 ` [PATCH v1 09/18] perf mem-events: Avoid uninitialized read Ian Rogers
2023-09-23 5:35 ` [PATCH v1 10/18] perf dlfilter: Be defensive against potential NULL dereference Ian Rogers
2023-09-23 5:35 ` [PATCH v1 11/18] perf hists browser: Reorder variables to reduce padding Ian Rogers
2023-09-23 5:35 ` [PATCH v1 12/18] perf hists browser: Avoid potential NULL dereference Ian Rogers
2023-09-23 5:35 ` [PATCH v1 13/18] perf svghelper: Avoid memory leak Ian Rogers
2023-09-23 5:35 ` [PATCH v1 14/18] perf parse-events: Fix unlikely memory leak when cloning terms Ian Rogers
2023-09-23 5:35 ` [PATCH v1 15/18] tools api: Avoid potential double free Ian Rogers
2023-09-23 5:35 ` [PATCH v1 16/18] perf trace-event-info: Avoid passing NULL value to closedir Ian Rogers
2023-09-23 5:35 ` [PATCH v1 17/18] perf header: Fix various error path memory leaks Ian Rogers
2023-09-23 5:35 ` Ian Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230923053515.535607-19-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=chenhuacai@kernel.org \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kan.liang@linux.intel.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=seanjc@google.com \
--cc=siyanteng@loongson.cn \
--cc=trix@redhat.com \
--cc=wangming01@loongson.cn \
--cc=yangjihong1@huawei.com \
--cc=yangyicong@hisilicon.com \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox