BPF List
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	 Tom Rix <trix@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,  Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	 Adrian Hunter <adrian.hunter@intel.com>,
	Yang Jihong <yangjihong1@huawei.com>,
	 Huacai Chen <chenhuacai@kernel.org>,
	Ming Wang <wangming01@loongson.cn>,
	 Kan Liang <kan.liang@linux.intel.com>,
	Ravi Bangoria <ravi.bangoria@amd.com>,
	llvm@lists.linux.dev,  linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,  bpf@vger.kernel.org
Subject: [PATCH v3 01/18] gen_compile_commands: Allow the line prefix to still be cmd_
Date: Mon,  9 Oct 2023 11:39:02 -0700	[thread overview]
Message-ID: <20231009183920.200859-2-irogers@google.com> (raw)
In-Reply-To: <20231009183920.200859-1-irogers@google.com>

Builds in tools still use the cmd_ prefix in .cmd files, so don't
require the saved part. Name the groups in the line pattern match so
that changing the regular expression is more robust and works with the
addition of a new match group.

Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
---
 scripts/clang-tools/gen_compile_commands.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py
index a84cc5737c2c..b43f9149893c 100755
--- a/scripts/clang-tools/gen_compile_commands.py
+++ b/scripts/clang-tools/gen_compile_commands.py
@@ -19,7 +19,7 @@ _DEFAULT_OUTPUT = 'compile_commands.json'
 _DEFAULT_LOG_LEVEL = 'WARNING'
 
 _FILENAME_PATTERN = r'^\..*\.cmd$'
-_LINE_PATTERN = r'^savedcmd_[^ ]*\.o := (.* )([^ ]*\.[cS]) *(;|$)'
+_LINE_PATTERN = r'^(saved)?cmd_[^ ]*\.o := (?P<command_prefix>.* )(?P<file_path>[^ ]*\.[cS]) *(;|$)'
 _VALID_LOG_LEVELS = ['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL']
 # The tools/ directory adopts a different build system, and produces .cmd
 # files in a different format. Do not support it.
@@ -213,8 +213,8 @@ def main():
                 result = line_matcher.match(f.readline())
                 if result:
                     try:
-                        entry = process_line(directory, result.group(1),
-                                             result.group(2))
+                        entry = process_line(directory, result.group('command_prefix'),
+                                             result.group('file_path'))
                         compile_commands.append(entry)
                     except ValueError as err:
                         logging.info('Could not add line from %s: %s',
-- 
2.42.0.609.gbb76f46606-goog


  reply	other threads:[~2023-10-09 18:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 18:39 [PATCH v3 00/18] clang-tools support in tools Ian Rogers
2023-10-09 18:39 ` Ian Rogers [this message]
2023-10-09 18:39 ` [PATCH v3 02/18] gen_compile_commands: Sort output compile commands by file name Ian Rogers
2023-10-09 18:39 ` [PATCH v3 03/18] run-clang-tools: Add pass through checks and and header-filter arguments Ian Rogers
2023-10-09 18:39 ` [PATCH v3 03/18] run-clang-tools: Add pass through checks " Ian Rogers
2023-10-09 18:39 ` [PATCH v3 04/18] perf bench uprobe: Fix potential use of memory after free Ian Rogers
2023-10-09 18:39 ` [PATCH v3 05/18] perf buildid-cache: Fix use of uninitialized value Ian Rogers
2023-10-09 18:39 ` [PATCH v3 06/18] perf env: Remove unnecessary NULL tests Ian Rogers
2023-10-09 18:39 ` [PATCH v3 07/18] perf jitdump: Avoid memory leak Ian Rogers
2023-10-09 18:39 ` [PATCH v3 08/18] perf mem-events: Avoid uninitialized read Ian Rogers
2023-10-09 18:39 ` [PATCH v3 09/18] perf dlfilter: Be defensive against potential NULL dereference Ian Rogers
2023-10-09 18:39 ` [PATCH v3 10/18] perf hists browser: Reorder variables to reduce padding Ian Rogers
2023-10-09 18:39 ` [PATCH v3 11/18] perf hists browser: Avoid potential NULL dereference Ian Rogers
2023-10-09 18:39 ` [PATCH v3 12/18] perf svghelper: Avoid memory leak Ian Rogers
2023-10-09 18:39 ` [PATCH v3 13/18] perf lock: Fix a memory leak on an error path Ian Rogers
2023-10-09 18:39 ` [PATCH v3 14/18] perf parse-events: Fix unlikely memory leak when cloning terms Ian Rogers
2023-10-09 18:39 ` [PATCH v3 15/18] tools api: Avoid potential double free Ian Rogers
2023-10-09 18:39 ` [PATCH v3 16/18] perf trace-event-info: Avoid passing NULL value to closedir Ian Rogers
2023-10-09 18:39 ` [PATCH v3 17/18] perf header: Fix various error path memory leaks Ian Rogers
2023-10-09 18:39 ` [PATCH v3 18/18] perf bpf_counter: Fix a few " Ian Rogers
2023-10-10  5:31 ` [PATCH v3 00/18] clang-tools support in tools Namhyung Kim
2023-10-12 17:23   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231009183920.200859-2-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=chenhuacai@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=trix@redhat.com \
    --cc=wangming01@loongson.cn \
    --cc=yangjihong1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox