From: kernel test robot <lkp@intel.com>
To: Dave Marchevsky <davemarchevsky@fb.com>, bpf@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>,
Kernel Team <kernel-team@fb.com>,
Dave Marchevsky <davemarchevsky@fb.com>
Subject: Re: [PATCH v1 bpf-next 3/4] btf: Descend into structs and arrays during special field search
Date: Thu, 26 Oct 2023 09:24:34 +0800 [thread overview]
Message-ID: <202310260952.C9Gb9Avi-lkp@intel.com> (raw)
In-Reply-To: <20231023220030.2556229-4-davemarchevsky@fb.com>
Hi Dave,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Dave-Marchevsky/bpf-Fix-btf_get_field_type-to-fail-for-multiple-bpf_refcount-fields/20231024-060227
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20231023220030.2556229-4-davemarchevsky%40fb.com
patch subject: [PATCH v1 bpf-next 3/4] btf: Descend into structs and arrays during special field search
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231026/202310260952.C9Gb9Avi-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231026/202310260952.C9Gb9Avi-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310260952.C9Gb9Avi-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/bpf/btf.c:3634:70: warning: variable 'off' is uninitialized when used here [-Wuninitialized]
ret = btf_find_struct_field(btf, elem_type, srch, array_field_off + off, rec);
^~~
kernel/bpf/btf.c:3625:15: note: initialize the variable 'off' to silence this warning
u32 i, j, off, nelems;
^
= 0
1 warning generated.
vim +/off +3634 kernel/bpf/btf.c
3616
3617 static int btf_flatten_array_field(const struct btf *btf,
3618 const struct btf_type *t,
3619 struct btf_field_info_search *srch,
3620 int array_field_off, int rec)
3621 {
3622 int ret, start_idx, elem_field_cnt;
3623 const struct btf_type *elem_type;
3624 struct btf_field_info *info;
3625 u32 i, j, off, nelems;
3626
3627 if (!btf_type_is_array(t))
3628 return -EINVAL;
3629 nelems = __multi_dim_elem_type_nelems(btf, t, &elem_type);
3630 if (!nelems || !__btf_type_is_struct(elem_type))
3631 return srch->idx;
3632
3633 start_idx = srch->idx;
> 3634 ret = btf_find_struct_field(btf, elem_type, srch, array_field_off + off, rec);
3635 if (ret < 0)
3636 return ret;
3637
3638 /* No btf_field_info's added */
3639 if (srch->idx == start_idx)
3640 return srch->idx;
3641
3642 elem_field_cnt = srch->idx - start_idx;
3643 info = __next_field_infos(srch, elem_field_cnt * (nelems - 1));
3644 if (IS_ERR_OR_NULL(info))
3645 return PTR_ERR(info);
3646
3647 /* Array elems after the first can copy first elem's btf_field_infos
3648 * and adjust offset
3649 */
3650 for (i = 1; i < nelems; i++) {
3651 memcpy(info, &srch->infos[start_idx],
3652 elem_field_cnt * sizeof(struct btf_field_info));
3653 for (j = 0; j < elem_field_cnt; j++) {
3654 info->off += (i * elem_type->size);
3655 info++;
3656 }
3657 }
3658 return srch->idx;
3659 }
3660
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-10-26 1:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 22:00 [PATCH v1 bpf-next 0/4] Descend into struct, array types when searching for fields Dave Marchevsky
2023-10-23 22:00 ` [PATCH v1 bpf-next 1/4] bpf: Fix btf_get_field_type to fail for multiple bpf_refcount fields Dave Marchevsky
2023-10-30 17:56 ` Yonghong Song
2023-11-01 21:56 ` Andrii Nakryiko
2023-10-23 22:00 ` [PATCH v1 bpf-next 2/4] bpf: Refactor btf_find_field with btf_field_info_search Dave Marchevsky
2023-10-28 14:52 ` Jiri Olsa
2023-10-30 19:31 ` Yonghong Song
2023-10-30 19:56 ` Yonghong Song
2023-11-01 21:56 ` Andrii Nakryiko
2023-10-23 22:00 ` [PATCH v1 bpf-next 3/4] btf: Descend into structs and arrays during special field search Dave Marchevsky
2023-10-26 1:24 ` kernel test robot [this message]
2023-10-30 12:56 ` Jiri Olsa
2023-10-30 20:56 ` Yonghong Song
2023-11-01 21:56 ` Andrii Nakryiko
2023-10-23 22:00 ` [PATCH v1 bpf-next 4/4] selftests/bpf: Add tests exercising aggregate type BTF " Dave Marchevsky
2023-10-23 23:32 ` kernel test robot
2023-10-30 21:10 ` Yonghong Song
2023-11-01 21:56 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310260952.C9Gb9Avi-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@fb.com \
--cc=kernel-team@fb.com \
--cc=llvm@lists.linux.dev \
--cc=martin.lau@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox