Re: [PATCH bpf-next 11/13] selftests/bpf: set BPF_F_TEST_SANITY_SCRIPT by default

Eduard Zingerman
2023-11-03T22:35:44Z

On Thu, 2023-11-02 at 17:08 -0700, Andrii Nakryiko wrote:
> Make sure to set BPF_F_TEST_SANITY_STRICT program flag by default across
> most verifier tests (and a bunch of others that set custom prog flags).
>
> There are currently two tests that do fail validation, if enforced
> strictly: verifier_bounds/crossing_64_bit_signed_boundary_2 and
> verifier_bounds/crossing_32_bit_signed_boundary_2. To accommodate them,
> we teach test_loader a flag negation:
>
> __flag(!<flagname>) will *clear* specified flag, allowing easy opt-out.
>
> We apply __flag(!BPF_F_TEST_SANITY_STRICT) to these to tests.
>
> Also sprinkle BPF_F_TEST_SANITY_STRICT everywhere where we already set
> test-only BPF_F_TEST_RND_HI32 flag, for completeness.
>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>

Acked-by: Eduard Zingerman <eddyz87@gmail.com> …