public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii@kernel.org>
To: <bpf@vger.kernel.org>, <ast@kernel.org>, <daniel@iogearbox.net>,
	<martin.lau@kernel.org>
Cc: <andrii@kernel.org>, <kernel-team@meta.com>
Subject: [PATCH v2 bpf 0/3] BPF control flow graph and precision backtrack fixes
Date: Thu, 9 Nov 2023 16:26:35 -0800	[thread overview]
Message-ID: <20231110002638.4168352-1-andrii@kernel.org> (raw)

A small fix to BPF verifier's CFG logic around handling and reporting ldimm64
instructions. Patch #1 was previously submitted separately ([0]), and so this
patch set supersedes that patch.

Second patch is fixing obscure corner case in mark_chain_precise() logic. See
patch for details. Patch #3 adds a dedicated test, however fragile it might.

  [0] https://patchwork.kernel.org/project/netdevbpf/patch/20231101205626.119243-1-andrii@kernel.org/


Andrii Nakryiko (3):
  bpf: handle ldimm64 properly in check_cfg()
  bpf: fix precision backtracking instruction iteration
  selftests/bpf: add edge case backtracking logic test

 include/linux/bpf.h                           |  8 +++-
 kernel/bpf/verifier.c                         | 48 +++++++++++++++----
 .../selftests/bpf/progs/verifier_precision.c  | 40 ++++++++++++++++
 .../testing/selftests/bpf/verifier/ld_imm64.c |  8 ++--
 4 files changed, 89 insertions(+), 15 deletions(-)

-- 
2.34.1


             reply	other threads:[~2023-11-10  0:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10  0:26 Andrii Nakryiko [this message]
2023-11-10  0:26 ` [PATCH v2 bpf 1/3] bpf: handle ldimm64 properly in check_cfg() Andrii Nakryiko
2023-11-10  0:26 ` [PATCH v2 bpf 2/3] bpf: fix precision backtracking instruction iteration Andrii Nakryiko
2023-11-10  0:26 ` [PATCH v2 bpf 3/3] selftests/bpf: add edge case backtracking logic test Andrii Nakryiko
2023-11-10  1:34   ` Alexei Starovoitov
2023-11-10  3:43     ` Andrii Nakryiko
2023-11-10  4:05       ` Andrii Nakryiko
2023-11-10  4:14         ` Alexei Starovoitov
2023-11-10  4:48           ` Andrii Nakryiko
2023-11-10  5:06             ` Andrii Nakryiko
2023-11-10  5:50 ` [PATCH v2 bpf 0/3] BPF control flow graph and precision backtrack fixes patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231110002638.4168352-1-andrii@kernel.org \
    --to=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@meta.com \
    --cc=martin.lau@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox