From: Eduard Zingerman <eddyz87@gmail.com>
To: bpf@vger.kernel.org, ast@kernel.org
Cc: andrii@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
kernel-team@fb.com, yonghong.song@linux.dev, memxor@gmail.com,
awerner32@gmail.com, Eduard Zingerman <eddyz87@gmail.com>
Subject: [PATCH bpf v4 09/11] selftests/bpf: test widening for iterating callbacks
Date: Tue, 21 Nov 2023 04:06:59 +0200 [thread overview]
Message-ID: <20231121020701.26440-10-eddyz87@gmail.com> (raw)
In-Reply-To: <20231121020701.26440-1-eddyz87@gmail.com>
A test case to verify that imprecise scalars widening is applied to
callback entering state, when callback call is simulated repeatedly.
Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
---
.../bpf/progs/verifier_iterating_callbacks.c | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/tools/testing/selftests/bpf/progs/verifier_iterating_callbacks.c b/tools/testing/selftests/bpf/progs/verifier_iterating_callbacks.c
index fa9429f77a81..598c1e984b26 100644
--- a/tools/testing/selftests/bpf/progs/verifier_iterating_callbacks.c
+++ b/tools/testing/selftests/bpf/progs/verifier_iterating_callbacks.c
@@ -25,6 +25,7 @@ struct buf_context {
struct num_context {
__u64 i;
+ __u64 j;
};
__u8 choice_arr[2] = { 0, 1 };
@@ -69,6 +70,25 @@ int unsafe_on_zero_iter(void *unused)
return choice_arr[loop_ctx.i];
}
+static int widening_cb(__u32 idx, struct num_context *ctx)
+{
+ ++ctx->i;
+ return 0;
+}
+
+SEC("?raw_tp")
+__success
+int widening(void *unused)
+{
+ struct num_context loop_ctx = { .i = 0, .j = 1 };
+
+ bpf_loop(100, widening_cb, &loop_ctx, 0);
+ /* loop_ctx.j is not changed during callback iteration,
+ * verifier should not apply widening to it.
+ */
+ return choice_arr[loop_ctx.j];
+}
+
static int loop_detection_cb(__u32 idx, struct num_context *ctx)
{
for (;;) {}
--
2.42.1
next prev parent reply other threads:[~2023-11-21 2:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 2:06 [PATCH bpf v4 00/11] verify callbacks as if they are called unknown number of times Eduard Zingerman
2023-11-21 2:06 ` [PATCH bpf v4 01/11] selftests/bpf: track tcp payload offset as scalar in xdp_synproxy Eduard Zingerman
2023-11-21 2:06 ` [PATCH bpf v4 02/11] selftests/bpf: track string payload offset as scalar in strobemeta Eduard Zingerman
2023-11-21 2:06 ` [PATCH bpf v4 03/11] selftests/bpf: fix bpf_loop_bench for new callback verification scheme Eduard Zingerman
2023-11-21 2:06 ` [PATCH bpf v4 04/11] bpf: extract __check_reg_arg() utility function Eduard Zingerman
2023-11-21 2:06 ` [PATCH bpf v4 05/11] bpf: extract setup_func_entry() " Eduard Zingerman
2023-11-21 2:06 ` [PATCH bpf v4 06/11] bpf: verify callbacks as if they are called unknown number of times Eduard Zingerman
2023-11-21 3:01 ` Alexei Starovoitov
2023-11-21 2:06 ` [PATCH bpf v4 07/11] selftests/bpf: tests for iterating callbacks Eduard Zingerman
2023-11-21 2:06 ` [PATCH bpf v4 08/11] bpf: widening for callback iterators Eduard Zingerman
2023-11-21 2:06 ` Eduard Zingerman [this message]
2023-11-21 2:07 ` [PATCH bpf v4 10/11] bpf: keep track of max number of bpf_loop callback iterations Eduard Zingerman
2023-11-21 2:07 ` [PATCH bpf v4 11/11] selftests/bpf: check if max number of bpf_loop iterations is tracked Eduard Zingerman
2023-11-21 3:10 ` [PATCH bpf v4 00/11] verify callbacks as if they are called unknown number of times patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121020701.26440-10-eddyz87@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=awerner32@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).