From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b4h5DLGR" Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86452A2 for ; Wed, 29 Nov 2023 11:20:40 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9e1021dbd28so15950966b.3 for ; Wed, 29 Nov 2023 11:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701285639; x=1701890439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y7cZeYFylMaxtzJfPZHbirUIFCzRX6DWKIf3smwQVOE=; b=b4h5DLGRO42t8GgdFDHtGTHN5fCKeRm1lGgK3P/FTZLjlh/VIIUoekxJSneCoAcMzW nuh3BVMB/pLyO1YFYxEVC7YPWJK7T8eWA0Q0t34vnzcpZ6ajVq8Ov9P9jgwJAI40I6mf kgur95Yo2XYZdl7j4Obq9dEGJHKPSGbUqdyskWPwqzNOVVpREXBG9wz5V1rWsLJOEMma dW/ahSgmS9uc7mHmea4lyXN1GwVijYBFU1/ThrbxPON0sRi6Z45EsnwTQs8D7GmIgWoL t8zOYa0iuyfnTF9cKHxMID+DNnCUpOQhhbHvf0rpflP6hHsohIaNJOwx8N1EnfrLwD5z 4smg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701285639; x=1701890439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y7cZeYFylMaxtzJfPZHbirUIFCzRX6DWKIf3smwQVOE=; b=tF3jKvauSOywUrnW5dE0MwEV+PiTsm9Lari103Wlvm5e4rEAO5p5f8hmeRV95rIrFO ydIM1HQXuMkZmf06WnatmTz0/oo8MD8uwfDj736HJLWYUvqSkP6n4ZL8fYWIbq4HSUF/ /qEd5r9GTbgSMT8S5RewiOydLR6VsBejTx17YRzYdGLEKXSxjl34qvkhOfb/Q6S01tOw HxTyV3mxHi7/oNTZx26S1Y7z9T0X5Gq/BQfnbxjKqW25tmdGsrB2RGeSC86xYl/rCjqc zPPyGNDWzrv7+qyaNmTmp4KJcSgffhCyfqacuJPhFpYeJrU/WBXMkv0anWLtkKNv7XBN 1AVw== X-Gm-Message-State: AOJu0YzKdP39go9TWTAx0bq7rhnPPON9tLjDRl21TgvBpmUmt18C0e1M BuoLkIRaNKuocZasJrhhejT7/yJ3aZDSYg== X-Google-Smtp-Source: AGHT+IG8PTj0mEF904wx9zMqrcLZJKi2VcK4t924yC7FZFnh7mPhhme+h+hTGGjHhl5CKO+hAeuvDA== X-Received: by 2002:a17:906:1009:b0:a01:9364:ec62 with SMTP id 9-20020a170906100900b00a019364ec62mr16495823ejm.8.1701285638927; Wed, 29 Nov 2023 11:20:38 -0800 (PST) Received: from erthalion.local (dslb-178-005-231-183.178.005.pools.vodafone-ip.de. [178.5.231.183]) by smtp.gmail.com with ESMTPSA id s16-20020a170906455000b009fd7bcd9054sm3596123ejq.147.2023.11.29.11.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 11:20:38 -0800 (PST) From: Dmitrii Dolgov <9erthalion6@gmail.com> To: bpf@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, dan.carpenter@linaro.org, olsajiri@gmail.com, Dmitrii Dolgov <9erthalion6@gmail.com> Subject: [PATCH bpf-next v3 2/3] selftests/bpf: Add test for recursive attachment of tracing progs Date: Wed, 29 Nov 2023 20:16:39 +0100 Message-ID: <20231129191643.6842-3-9erthalion6@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231129191643.6842-1-9erthalion6@gmail.com> References: <20231129191643.6842-1-9erthalion6@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Verify the fact that an fentry prog could be attached to another one, building up an attachment chain of limited size. Use existing bpf_testmod as a start of the chain. Note, that currently it's not possible to: * form a cycle within an attachment chain * splice two attachment chains Those limitations are coming from the fact that attach_prog_fd is specified at the prog load (thus making it impossible to attach to a program loaded after it in this way), as well as tracing progs not implementing link_detach. This is the reason there is only one test for the chain length. Signed-off-by: Dmitrii Dolgov <9erthalion6@gmail.com> --- .../bpf/prog_tests/recursive_attach.c | 85 +++++++++++++++++++ .../selftests/bpf/progs/fentry_recursive.c | 19 +++++ .../bpf/progs/fentry_recursive_target.c | 20 +++++ 3 files changed, 124 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/recursive_attach.c create mode 100644 tools/testing/selftests/bpf/progs/fentry_recursive.c create mode 100644 tools/testing/selftests/bpf/progs/fentry_recursive_target.c diff --git a/tools/testing/selftests/bpf/prog_tests/recursive_attach.c b/tools/testing/selftests/bpf/prog_tests/recursive_attach.c new file mode 100644 index 000000000000..9c422dd92c4e --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/recursive_attach.c @@ -0,0 +1,85 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2023 Red Hat, Inc. */ +#include +#include "fentry_recursive.skel.h" +#include "fentry_recursive_target.skel.h" +#include +#include "bpf/libbpf_internal.h" + +#define ATTACH_DEPTH 33 + +/* + * Test following scenarios: + * - one can attach fentry progs recursively, one fentry to another one + * - an attachment chain generated this way is limited, after 32 attachment no + * more progs could be added + */ +void test_recursive_fentry_attach(void) +{ + struct fentry_recursive_target *target_skel = NULL; + struct fentry_recursive *tracing_chain[ATTACH_DEPTH + 1] = {}; + struct bpf_program *prog; + int prev_fd, err; + + target_skel = fentry_recursive_target__open_and_load(); + if (!ASSERT_OK_PTR(target_skel, "fentry_recursive_target__open_and_load")) + goto close_prog; + + /* This is going to be the start of the chain */ + tracing_chain[0] = fentry_recursive__open(); + if (!ASSERT_OK_PTR(tracing_chain[0], "fentry_recursive__open")) + goto close_prog; + + prog = tracing_chain[0]->progs.recursive_attach; + prev_fd = bpf_program__fd(target_skel->progs.test1); + err = bpf_program__set_attach_target(prog, prev_fd, "test1"); + if (!ASSERT_OK(err, "bpf_program__set_attach_target")) + goto close_prog; + + err = fentry_recursive__load(tracing_chain[0]); + if (!ASSERT_OK(err, "fentry_recursive__load")) + goto close_prog; + + /* Create an attachment chain to exhaust the limit */ + for (int i = 1; i < ATTACH_DEPTH; i++) { + tracing_chain[i] = fentry_recursive__open(); + if (!ASSERT_OK_PTR(tracing_chain[i], "fentry_recursive__open")) + goto close_prog; + + prog = tracing_chain[i]->progs.recursive_attach; + prev_fd = bpf_program__fd(tracing_chain[i-1]->progs.recursive_attach); + err = bpf_program__set_attach_target(prog, prev_fd, "recursive_attach"); + if (!ASSERT_OK(err, "bpf_program__set_attach_target")) + goto close_prog; + + err = fentry_recursive__load(tracing_chain[i]); + if (!ASSERT_OK(err, "fentry_recursive__load")) + goto close_prog; + + err = fentry_recursive__attach(tracing_chain[i]); + if (!ASSERT_OK(err, "fentry_recursive__attach")) + goto close_prog; + } + + /* The next attachment would fail */ + tracing_chain[ATTACH_DEPTH] = fentry_recursive__open(); + if (!ASSERT_OK_PTR(tracing_chain[ATTACH_DEPTH], "last fentry_recursive__open")) + goto close_prog; + + prog = tracing_chain[ATTACH_DEPTH]->progs.recursive_attach; + prev_fd = bpf_program__fd(tracing_chain[ATTACH_DEPTH - 1]->progs.recursive_attach); + err = bpf_program__set_attach_target(prog, prev_fd, "recursive_attach"); + if (!ASSERT_OK(err, "last bpf_program__set_attach_target")) + goto close_prog; + + err = fentry_recursive__load(tracing_chain[ATTACH_DEPTH]); + if (!ASSERT_ERR(err, "last fentry_recursive__load")) + goto close_prog; + +close_prog: + fentry_recursive_target__destroy(target_skel); + for (int i = 1; i < ATTACH_DEPTH + 1; i++) { + if (tracing_chain[i]) + fentry_recursive__destroy(tracing_chain[i]); + } +} diff --git a/tools/testing/selftests/bpf/progs/fentry_recursive.c b/tools/testing/selftests/bpf/progs/fentry_recursive.c new file mode 100644 index 000000000000..1df490230344 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/fentry_recursive.c @@ -0,0 +1,19 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2023 Red Hat, Inc. */ +#include +#include +#include + +char _license[] SEC("license") = "GPL"; + +__u64 test1_result = 0; + +/* + * Dummy fentry bpf prog for testing fentry attachment chains + */ +SEC("fentry/XXX") +int BPF_PROG(recursive_attach, int a) +{ + test1_result = a == 1; + return 0; +} diff --git a/tools/testing/selftests/bpf/progs/fentry_recursive_target.c b/tools/testing/selftests/bpf/progs/fentry_recursive_target.c new file mode 100644 index 000000000000..b6fb8ebd598d --- /dev/null +++ b/tools/testing/selftests/bpf/progs/fentry_recursive_target.c @@ -0,0 +1,20 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2023 Red Hat, Inc. */ +#include +#include +#include + +char _license[] SEC("license") = "GPL"; + +__u64 test1_result = 0; + +/* + * Dummy fentry bpf prog for testing fentry attachment chains. It's going to be + * a start of the chain. + */ +SEC("fentry/bpf_testmod_fentry_test1") +int BPF_PROG(test1, int a) +{ + test1_result = a == 1; + return 0; +} -- 2.41.0