From: thinker.li@gmail.com
To: bpf@vger.kernel.org, ast@kernel.org, martin.lau@linux.dev,
song@kernel.org, kernel-team@meta.com, andrii@kernel.org,
drosen@google.com
Cc: sinquersw@gmail.com, kuifeng@meta.com,
Kui-Feng Lee <thinker.li@gmail.com>
Subject: [PATCH bpf-next v14 04/14] bpf: add struct_ops_tab to btf.
Date: Sun, 17 Dec 2023 00:11:21 -0800 [thread overview]
Message-ID: <20231217081132.1025020-5-thinker.li@gmail.com> (raw)
In-Reply-To: <20231217081132.1025020-1-thinker.li@gmail.com>
From: Kui-Feng Lee <thinker.li@gmail.com>
Maintain a registry of registered struct_ops types in the per-btf (module)
struct_ops_tab. This registry allows for easy lookup of struct_ops types
that are registered by a specific module.
It is a preparation work for supporting kernel module struct_ops in a
latter patch. Each struct_ops will be registered under its own kernel
module btf and will be stored in the newly added btf->struct_ops_tab. The
bpf verifier and bpf syscall (e.g. prog and map cmd) can find the
struct_ops and its btf type/size/id... information from
btf->struct_ops_tab.
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
---
include/linux/btf.h | 2 ++
kernel/bpf/btf.c | 62 +++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 64 insertions(+)
diff --git a/include/linux/btf.h b/include/linux/btf.h
index 1d852dad7473..a68604904f4e 100644
--- a/include/linux/btf.h
+++ b/include/linux/btf.h
@@ -584,4 +584,6 @@ static inline bool btf_type_is_struct_ptr(struct btf *btf, const struct btf_type
return btf_type_is_struct(t);
}
+struct bpf_struct_ops_desc;
+
#endif
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index 46bf3a6f4bb0..2ce2c3fd477e 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -241,6 +241,12 @@ struct btf_id_dtor_kfunc_tab {
struct btf_id_dtor_kfunc dtors[];
};
+struct btf_struct_ops_tab {
+ u32 cnt;
+ u32 capacity;
+ struct bpf_struct_ops_desc ops[];
+};
+
struct btf {
void *data;
struct btf_type **types;
@@ -258,6 +264,7 @@ struct btf {
struct btf_kfunc_set_tab *kfunc_set_tab;
struct btf_id_dtor_kfunc_tab *dtor_kfunc_tab;
struct btf_struct_metas *struct_meta_tab;
+ struct btf_struct_ops_tab *struct_ops_tab;
/* split BTF support */
struct btf *base_btf;
@@ -1688,11 +1695,20 @@ static void btf_free_struct_meta_tab(struct btf *btf)
btf->struct_meta_tab = NULL;
}
+static void btf_free_struct_ops_tab(struct btf *btf)
+{
+ struct btf_struct_ops_tab *tab = btf->struct_ops_tab;
+
+ kfree(tab);
+ btf->struct_ops_tab = NULL;
+}
+
static void btf_free(struct btf *btf)
{
btf_free_struct_meta_tab(btf);
btf_free_dtor_kfunc_tab(btf);
btf_free_kfunc_set_tab(btf);
+ btf_free_struct_ops_tab(btf);
kvfree(btf->types);
kvfree(btf->resolved_sizes);
kvfree(btf->resolved_ids);
@@ -8597,3 +8613,49 @@ bool btf_type_ids_nocast_alias(struct bpf_verifier_log *log,
return !strncmp(reg_name, arg_name, cmp_len);
}
+
+static int
+btf_add_struct_ops(struct btf *btf, struct bpf_struct_ops *st_ops)
+{
+ struct btf_struct_ops_tab *tab, *new_tab;
+ int i;
+
+ if (!btf)
+ return -ENOENT;
+
+ /* Assume this function is called for a module when the module is
+ * loading.
+ */
+
+ tab = btf->struct_ops_tab;
+ if (!tab) {
+ tab = kzalloc(offsetof(struct btf_struct_ops_tab, ops[4]),
+ GFP_KERNEL);
+ if (!tab)
+ return -ENOMEM;
+ tab->capacity = 4;
+ btf->struct_ops_tab = tab;
+ }
+
+ for (i = 0; i < tab->cnt; i++)
+ if (tab->ops[i].st_ops == st_ops)
+ return -EEXIST;
+
+ if (tab->cnt == tab->capacity) {
+ new_tab = krealloc(tab,
+ offsetof(struct btf_struct_ops_tab,
+ ops[tab->capacity * 2]),
+ GFP_KERNEL);
+ if (!new_tab)
+ return -ENOMEM;
+ tab = new_tab;
+ tab->capacity *= 2;
+ btf->struct_ops_tab = tab;
+ }
+
+ tab->ops[btf->struct_ops_tab->cnt].st_ops = st_ops;
+
+ btf->struct_ops_tab->cnt++;
+
+ return 0;
+}
--
2.34.1
next prev parent reply other threads:[~2023-12-17 8:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 8:11 [PATCH bpf-next v14 00/14] Registrating struct_ops types from modules thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 01/14] bpf: refactory struct_ops type initialization to a function thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 02/14] bpf: get type information with BTF_ID_LIST thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 03/14] bpf, net: introduce bpf_struct_ops_desc thinker.li
2023-12-17 8:11 ` thinker.li [this message]
2023-12-17 8:11 ` [PATCH bpf-next v14 05/14] bpf: make struct_ops_map support btfs other than btf_vmlinux thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 06/14] bpf: pass btf object id in bpf_map_info thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 07/14] bpf: lookup struct_ops types from a given module BTF thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 08/14] bpf: pass attached BTF to the bpf_struct_ops subsystem thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 09/14] bpf: hold module refcnt in bpf_struct_ops map creation and prog verification thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 10/14] bpf: validate value_type thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 11/14] bpf, net: switch to dynamic registration thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 12/14] libbpf: Find correct module BTFs for struct_ops maps and progs thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 13/14] bpf: export btf_ctx_access to modules thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 14/14] selftests/bpf: test case for register_bpf_struct_ops() thinker.li
2023-12-17 8:11 ` [PATCH bpf-next v14 06/14] bpf: pass btf object id in bpf_map_info thinker.li
2023-12-18 17:05 ` Kui-Feng Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231217081132.1025020-5-thinker.li@gmail.com \
--to=thinker.li@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=drosen@google.com \
--cc=kernel-team@meta.com \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=sinquersw@gmail.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox