From: Christian Brauner <brauner@kernel.org>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
torvalds@linuxfoundation.org, ast@kernel.org,
daniel@iogearbox.net, linux-fsdevel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH bpf-next] bpf: add BPF_F_TOKEN_FD flag to pass with BPF token FD
Date: Wed, 20 Dec 2023 13:10:10 +0100 [thread overview]
Message-ID: <20231220-drillen-obskur-a310578e99bb@brauner> (raw)
In-Reply-To: <20231219053150.336991-1-andrii@kernel.org>
On Mon, Dec 18, 2023 at 09:31:50PM -0800, Andrii Nakryiko wrote:
> Add BPF_F_TOKEN_FD flag to be used across bpf() syscall commands
> that accept BPF token FD: BPF_PROG_LOAD, BPF_MAP_CREATE, and
> BPF_BTF_LOAD. This flag has to be set whenever token FD is provided.
>
> BPF_BTF_LOAD command didn't have a flags field, so add it as well.
>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> ---
Reviewed-by: Christian Brauner <brauner@kernel.org>
> /* Get path from provided FD in BPF_OBJ_PIN/BPF_OBJ_GET commands */
> BPF_F_PATH_FD = (1U << 14),
> +
> +/* BPF token FD is passed in a corresponding command's token_fd field */
> + BPF_F_TOKEN_FD = (1U << 15),
The placement of the new flag right after the BPF_F_PATH_FD flag alone
does tell us everything about the "we didn't know" claims wrt to the
token fd stuff. Literally the same review and the same solution I
requested back then.
prev parent reply other threads:[~2023-12-20 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 5:31 [PATCH bpf-next] bpf: add BPF_F_TOKEN_FD flag to pass with BPF token FD Andrii Nakryiko
2023-12-20 12:10 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220-drillen-obskur-a310578e99bb@brauner \
--to=brauner@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox