From: Greg KH <greg@kroah.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: stable@vger.kernel.org, bpf@vger.kernel.org,
Daniel Borkmann <daniel@iogearbox.net>,
Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
Alan Maguire <alan.maguire@oracle.com>
Subject: Re: [PATCH stable 6.1 2/2] bpf: Add --skip_encoding_btf_inconsistent_proto, --btf_gen_optimized to pahole flags for v1.25
Date: Wed, 17 Jan 2024 12:02:44 +0100 [thread overview]
Message-ID: <2024011730-droplet-related-5a61@gregkh> (raw)
In-Reply-To: <20240117094424.487462-3-jolsa@kernel.org>
On Wed, Jan 17, 2024 at 10:44:24AM +0100, Jiri Olsa wrote:
> From: Alan Maguire <alan.maguire@oracle.com>
>
> commit 7b99f75942da332e3f4f865e55a10fec95a30d4f upstream.
>
> v1.25 of pahole supports filtering out functions with multiple inconsistent
> function prototypes or optimized-out parameters from the BTF representation.
> These present problems because there is no additional info in BTF saying which
> inconsistent prototype matches which function instance to help guide attachment,
> and functions with optimized-out parameters can lead to incorrect assumptions
> about register contents.
>
> So for now, filter out such functions while adding BTF representations for
> functions that have "."-suffixes (foo.isra.0) but not optimized-out parameters.
> This patch assumes that below linked changes land in pahole for v1.25.
>
> Issues with pahole filtering being too aggressive in removing functions
> appear to be resolved now, but CI and further testing will confirm.
>
> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
> Link: https://lore.kernel.org/r/20230510130241.1696561-1-alan.maguire@oracle.com
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> ---
> scripts/pahole-flags.sh | 3 +++
> 1 file changed, 3 insertions(+)
Again, a signed-off-by please.
Resend the whole series?
thanks,
greg k-h
next prev parent reply other threads:[~2024-01-17 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 9:44 [PATCH stable 6.1 0/2] btf, scripts: Update pahole options Jiri Olsa
2024-01-17 9:44 ` [PATCH stable 6.1 1/2] btf, scripts: Exclude Rust CUs with pahole Jiri Olsa
2024-01-17 11:02 ` Greg KH
2024-01-17 9:44 ` [PATCH stable 6.1 2/2] bpf: Add --skip_encoding_btf_inconsistent_proto, --btf_gen_optimized to pahole flags for v1.25 Jiri Olsa
2024-01-17 11:02 ` Greg KH [this message]
2024-01-17 13:19 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024011730-droplet-related-5a61@gregkh \
--to=greg@kroah.com \
--cc=alan.maguire@oracle.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox