From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
To: bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@kernel.org>,
Barret Rhoden <brho@google.com>,
David Vernet <void@manifault.com>, Tejun Heo <tj@kernel.org>
Subject: [PATCH bpf-next v1 0/2] Enable static subprog calls in spin lock critical sections
Date: Sun, 4 Feb 2024 12:02:04 +0000 [thread overview]
Message-ID: <20240204120206.796412-1-memxor@gmail.com> (raw)
This set allows a BPF program to make a call to a static subprog within
a bpf_spin_lock critical section. This problem has been hit in sched-ext
and ghOSt [0] as well, and is mostly an annoyance which is worked around
by inling the static subprog into the critical section.
In case of sched-ext, there are a lot of other helper/kfunc calls that
need to be allow listed for the support to be complete, but a separate
follow up will deal with that.
Unlike static subprogs, global subprogs cannot be allowed yet as the
verifier will not explore their body when encountering a call
instruction for them. Therefore, we would need an alternative approach
(some sort of function summarization to ensure a lock is never taken
from a global subprog and all its callees).
[0]: https://lore.kernel.org/bpf/bd173bf2-dea6-3e0e-4176-4a9256a9a056@google.com
Kumar Kartikeya Dwivedi (2):
bpf: Allow calling static subprogs while holding a bpf_spin_lock
selftests/bpf: Add test for static subprog call in lock cs
kernel/bpf/verifier.c | 10 ++-
.../selftests/bpf/prog_tests/spin_lock.c | 2 +
.../selftests/bpf/progs/test_spin_lock.c | 65 +++++++++++++++++++
.../selftests/bpf/progs/test_spin_lock_fail.c | 44 +++++++++++++
.../selftests/bpf/progs/verifier_spin_lock.c | 2 +-
5 files changed, 119 insertions(+), 4 deletions(-)
base-commit: 2a79690eae953daaac232f93e6c5ac47ac539f2d
--
2.40.1
next reply other threads:[~2024-02-04 12:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 12:02 Kumar Kartikeya Dwivedi [this message]
2024-02-04 12:02 ` [PATCH bpf-next v1 1/2] bpf: Allow calling static subprogs while holding a bpf_spin_lock Kumar Kartikeya Dwivedi
2024-02-04 21:23 ` Yonghong Song
2024-02-04 22:09 ` Kumar Kartikeya Dwivedi
2024-02-04 21:33 ` David Vernet
2024-02-04 22:10 ` Kumar Kartikeya Dwivedi
2024-02-04 23:55 ` Yonghong Song
2024-02-04 12:02 ` [PATCH bpf-next v1 2/2] selftests/bpf: Add test for static subprog call in lock cs Kumar Kartikeya Dwivedi
2024-02-04 21:26 ` Yonghong Song
2024-02-04 21:36 ` David Vernet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240204120206.796412-1-memxor@gmail.com \
--to=memxor@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brho@google.com \
--cc=daniel@iogearbox.net \
--cc=martin.lau@kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox