BPF List
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: bpf@vger.kernel.org
Cc: "Björn Töpel" <bjorn@kernel.org>,
	"Magnus Karlsson" <magnus.karlsson@intel.com>,
	"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
	"Jonathan Lemon" <jonathan.lemon@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH bpf] xsk: Add truesize to skb_add_rx_frag().
Date: Tue, 13 Feb 2024 16:37:37 +0100	[thread overview]
Message-ID: <20240213153737.6ukdoJKc@linutronix.de> (raw)
In-Reply-To: <20240202163221.2488589-1-bigeasy@linutronix.de>

On 2024-02-02 17:32:20 [+0100], To bpf@vger.kernel.org wrote:
> xsk_build_skb() allocates a page and adds it to the skb via
> skb_add_rx_frag() and specifies 0 for truesize. This leads to a warning
> in skb_add_rx_frag() with CONFIG_DEBUG_NET enabled because size is
> larger than truesize.
> 
> Increasing truesize requires to add the same amount to socket's
> sk_wmem_alloc counter in order not to underflow the counter during
> release in the destructor (sock_wfree()).
> 
> Pass the size of the allocated page as truesize to skb_add_rx_frag().
> Add this mount to socket's sk_wmem_alloc counter.
> 
> Fixes: cf24f5a5feea ("xsk: add support for AF_XDP multi-buffer on Tx path")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Is this stuck somewhere or just waiting for review/ etc?
Patchwork says new and the ci failure on s390x seems unrelated.

Sebastian

  parent reply	other threads:[~2024-02-13 15:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02 16:32 [PATCH bpf] xsk: Add truesize to skb_add_rx_frag() Sebastian Andrzej Siewior
2024-02-05 23:13 ` Maciej Fijalkowski
2024-02-13 15:37 ` Sebastian Andrzej Siewior [this message]
2024-02-13 15:59   ` Maciej Fijalkowski
2024-02-13 16:02     ` Sebastian Andrzej Siewior
2024-02-13 22:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240213153737.6ukdoJKc@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=bjorn@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=jonathan.lemon@gmail.com \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox