Re: [PATCH 2/4] mm: pgalloc: support address-conditional pmd allocation

[kernel test robot <lkp@intel.com>]

Hi Maxwell,

kernel test robot noticed the following build errors:

[auto build test ERROR on b401b621758e46812da61fa58a67c3fd8d91de0d]

url:    https://github.com/intel-lab-lkp/linux/commits/Maxwell-Bland/mm-vmalloc-allow-arch-specific-vmalloc_node-overrides/20240221-043458
base:   b401b621758e46812da61fa58a67c3fd8d91de0d
patch link:    https://lore.kernel.org/r/20240220203256.31153-3-mbland%40motorola.com
patch subject: [PATCH 2/4] mm: pgalloc: support address-conditional pmd allocation
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240222/202402220006.5v6axq6B-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240222/202402220006.5v6axq6B-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402220006.5v6axq6B-lkp@intel.com/

All errors (new ones prefixed by >>):

>> mm/memory.c:459:3: error: implicit declaration of function 'pmd_populate_kernel_at' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                   pmd_populate_kernel_at(&init_mm, pmd, new, address);
                   ^
   mm/memory.c:459:3: note: did you mean 'pmd_populate_kernel'?
   arch/arm/include/asm/pgalloc.h:125:1: note: 'pmd_populate_kernel' declared here
   pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmdp, pte_t *ptep)
   ^
   1 error generated.


vim +/pmd_populate_kernel_at +459 mm/memory.c

   449	
   450	int __pte_alloc_kernel(pmd_t *pmd, unsigned long address)
   451	{
   452		pte_t *new = pte_alloc_one_kernel(&init_mm);
   453		if (!new)
   454			return -ENOMEM;
   455	
   456		spin_lock(&init_mm.page_table_lock);
   457		if (likely(pmd_none(*pmd))) {	/* Has another populated it ? */
   458			smp_wmb(); /* See comment in pmd_install() */
 > 459			pmd_populate_kernel_at(&init_mm, pmd, new, address);
   460			new = NULL;
   461		}
   462		spin_unlock(&init_mm.page_table_lock);
   463		if (new)
   464			pte_free_kernel(&init_mm, new);
   465		return 0;
   466	}
   467	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki