From: Yonghong Song <yonghong.song@linux.dev>
To: bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com, Martin KaFai Lau <martin.lau@kernel.org>
Subject: [PATCH bpf-next 0/4] selftests/bpf: Fix a couple of test failures with LTO kernel
Date: Sat, 2 Mar 2024 08:50:17 -0800 [thread overview]
Message-ID: <20240302165017.1627295-1-yonghong.song@linux.dev> (raw)
With a LTO kernel built with clang, I encountered two test failures,
ksyms and kprobe_multi_bench_attach/kernel. Both test failures are
due to static variable/function renaming due to cross-file inlining.
The solution is to either skip the test or filter out those renamed
functions. A helper function check_lto_kernel() is introduced to
identify whether the underlying kernel is built with LTO or not.
Please see each individual patches for details.
Yonghong Song (4):
selftests/bpf: Replace CHECK with ASSERT macros for ksyms test
selftests/bpf: Add check_lto_kernel() helper
selftests/bpf: Fix possible ksyms test failure with LTO kernel
selftests/bpf: Fix possible kprobe_multi_bench_attach test failure
with LTO kernel
.../bpf/prog_tests/kprobe_multi_test.c | 7 +++
.../testing/selftests/bpf/prog_tests/ksyms.c | 42 +++++++++--------
tools/testing/selftests/bpf/testing_helpers.c | 47 +++++++++++++++++++
tools/testing/selftests/bpf/testing_helpers.h | 1 +
4 files changed, 78 insertions(+), 19 deletions(-)
--
2.43.0
next reply other threads:[~2024-03-02 16:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 16:50 Yonghong Song [this message]
2024-03-02 16:50 ` [PATCH bpf-next 1/4] selftests/bpf: Replace CHECK with ASSERT macros for ksyms test Yonghong Song
2024-03-05 0:17 ` Andrii Nakryiko
2024-03-05 7:21 ` Yonghong Song
2024-03-02 16:50 ` [PATCH bpf-next 2/4] selftests/bpf: Add check_lto_kernel() helper Yonghong Song
2024-03-02 16:50 ` [PATCH bpf-next 3/4] selftests/bpf: Fix possible ksyms test failure with LTO kernel Yonghong Song
2024-03-05 5:37 ` Alexei Starovoitov
2024-03-05 7:24 ` Yonghong Song
2024-03-02 16:50 ` [PATCH bpf-next 4/4] selftests/bpf: Fix possible kprobe_multi_bench_attach " Yonghong Song
-- strict thread matches above, loose matches on Subject: below --
2024-03-02 16:20 [PATCH bpf-next 0/4] selftests/bpf: Fix a couple of test failures " Yonghong Song
2024-03-02 16:49 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240302165017.1627295-1-yonghong.song@linux.dev \
--to=yonghong.song@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox