From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org,
jolsa@kernel.org, "Paul E . McKenney" <paulmck@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] ftrace: make extra rcu_is_watching() validation check optional
Date: Mon, 1 Apr 2024 20:25:52 +0900 [thread overview]
Message-ID: <20240401202552.470d845bd79c841b9158fb56@kernel.org> (raw)
In-Reply-To: <20240326150121.68e9db8a@gandalf.local.home>
On Tue, 26 Mar 2024 15:01:21 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 26 Mar 2024 09:16:33 -0700
> Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
>
> > > It's no different than lockdep. Test boxes should have it enabled, but
> > > there's no reason to have this enabled in a production system.
> > >
> >
> > I tend to agree with Steven here (which is why I sent this patch as it
> > is), but I'm happy to do it as an opt-out, if Masami insists. Please
> > do let me know if I need to send v2 or this one is actually the one
> > we'll end up using. Thanks!
>
> Masami,
>
> Are you OK with just keeping it set to N.
OK, if it is only for the debugging, I'm OK to set N this.
>
> We could have other options like PROVE_LOCKING enable it.
Agreed (but it should say this is a debug option)
Thank you,
>
> -- Steve
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2024-04-01 11:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 16:03 [PATCH] ftrace: make extra rcu_is_watching() validation check optional Andrii Nakryiko
2024-03-25 2:38 ` Masami Hiramatsu
2024-03-25 16:56 ` Andrii Nakryiko
2024-03-25 22:13 ` Steven Rostedt
2024-03-26 16:16 ` Andrii Nakryiko
2024-03-26 19:01 ` Steven Rostedt
2024-03-29 16:39 ` Andrii Nakryiko
2024-04-01 11:25 ` Masami Hiramatsu [this message]
2024-04-01 16:09 ` Steven Rostedt
2024-04-02 0:38 ` Masami Hiramatsu
2024-04-02 2:29 ` Andrii Nakryiko
2024-04-02 2:47 ` Steven Rostedt
2024-04-03 0:40 ` Masami Hiramatsu
2024-04-03 0:54 ` Steven Rostedt
2024-04-03 4:00 ` Andrii Nakryiko
2024-04-03 5:21 ` Andrii Nakryiko
2024-04-03 13:55 ` Steven Rostedt
2024-04-06 3:41 ` Masami Hiramatsu
2024-04-06 16:06 ` Andrii Nakryiko
2024-04-03 13:53 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240401202552.470d845bd79c841b9158fb56@kernel.org \
--to=mhiramat@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox