From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Camelia Groza <camelia.groza@nxp.com>,
David Gouarin <dgouarin@gmail.com>,
david.gouarin@thalesgroup.com,
Madalin Bucur <madalin.bucur@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net v4] dpaa_eth: fix XDP queue index
Date: Thu, 18 Apr 2024 10:51:28 +0300 [thread overview]
Message-ID: <20240418075128.m4v4f3nlrzn3qlfl@skbuf> (raw)
In-Reply-To: <20240417181734.7ebc844f@kernel.org>
On Wed, Apr 17, 2024 at 06:17:34PM -0700, Jakub Kicinski wrote:
> On Thu, 11 Apr 2024 14:34:33 +0300 Vladimir Oltean wrote:
> > On Wed, Apr 10, 2024 at 07:40:55PM -0700, Jakub Kicinski wrote:
> > > On Tue, 9 Apr 2024 11:30:46 +0200 David Gouarin wrote:
> > > > Make it possible to bind a XDP socket to a queue id.
> > > > The DPAA FQ Id was passed to the XDP program in the
> > > > xdp_rxq_info->queue_index instead of the Ethernet device queue number,
> > > > which made it unusable with bpf_map_redirect.
> > > > Instead of the DPAA FQ Id, initialise the XDP rx queue with the queue number.
> > >
> > > Camelia, looks good?
> >
> > Please allow me some time to prepare a response, even if this means the
> > patch misses this week's 'net' pull request.
>
> We're getting close to the 'net' pull request of the following week :)
> The bug has been around for a while so no huge rush, but would be nice
> to get rid of this from patchwork. If you don't have time - would you
> be willing to repost it once you found the time to investigate?
I have been looking into this, but I do not have a definitive response yet.
The dpaa_fq->channel replacement is not the zero-based RX queue number
that David is looking for, either.
We will work this out. Please remove this patch from patchwork for now.
prev parent reply other threads:[~2024-04-18 7:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZeiNxaq3jzloO9l6@boxer>
2024-03-07 14:24 ` [PATCH net v2] dpaa_eth: fix XDP queue index David Gouarin
2024-03-07 15:51 ` Maciej Fijalkowski
2024-03-07 17:48 ` david gouarin
2024-03-20 11:25 ` [PATCH net v3] " David Gouarin
2024-03-21 12:26 ` Paolo Abeni
2024-04-09 9:30 ` [PATCH net v4] " David Gouarin
2024-04-11 2:40 ` Jakub Kicinski
2024-04-11 11:34 ` Vladimir Oltean
2024-04-18 1:17 ` Jakub Kicinski
2024-04-18 7:51 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418075128.m4v4f3nlrzn3qlfl@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=camelia.groza@nxp.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=david.gouarin@thalesgroup.com \
--cc=dgouarin@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox