From: Jakub Kicinski <kuba@kernel.org>
To: Miao Xu <miaxu@meta.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Martin Lau <kafai@meta.com>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>
Subject: Re: [PATCH net-next v2 1/3] Add new args for cong_control in tcp_congestion_ops
Date: Wed, 1 May 2024 06:26:53 -0700 [thread overview]
Message-ID: <20240501062653.09abec31@kernel.org> (raw)
In-Reply-To: <20240501074338.362361-1-miaxu@meta.com>
On Wed, 1 May 2024 00:43:36 -0700 Miao Xu wrote:
> This patch adds two new arguments for cong_control of struct
> tcp_congestion_ops:
> - ack
> - flag
> These two arguments are inherited from the caller tcp_cong_control in
> tcp_intput.c. One use case of them is to update cwnd and pacing rate
> inside cong_control based on the info they provide. For example, the
> flag can be used to decide if it is the right time to raise or reduce a
> sender's cwnd.
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> --
three dashes here ---
> Changes in v2:
> * Split the v1 patch into 2 separate patches. In particular, spin out
> bpf_tcp_ca.c as a separate patch because it is bpf specific.
>
> Signed-off-by: Miao Xu <miaxu@meta.com>
This goes after Eric's review tag.
Looks like you need to adjust one of the BPF selftests:
Error: #29/14 bpf_tcp_ca/tcp_ca_kfunc
Error: #29/14 bpf_tcp_ca/tcp_ca_kfunc
libbpf: extern (func ksym) 'bbr_main': func_proto [213] incompatible with vmlinux [48152]
libbpf: failed to load object 'tcp_ca_kfunc'
libbpf: failed to load BPF skeleton 'tcp_ca_kfunc': -22
test_tcp_ca_kfunc:FAIL:tcp_ca_kfunc__open_and_load unexpected error: -22
prev parent reply other threads:[~2024-05-01 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 7:43 [PATCH net-next v2 1/3] Add new args for cong_control in tcp_congestion_ops Miao Xu
2024-05-01 7:43 ` [PATCH net-next v2 2/3] Allow to write tp->snd_cwnd_stamp in bpf_tcp_ca Miao Xu
2024-05-01 7:43 ` [PATCH net-next v2 3/3] Add test for the use of new args in cong_control Miao Xu
2024-05-01 20:19 ` Martin KaFai Lau
2024-05-02 0:39 ` Jakub Kicinski
2024-05-01 13:26 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501062653.09abec31@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kafai@meta.com \
--cc=miaxu@meta.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).