bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Vernet <void@manifault.com>
To: Dave Thaler <dthaler1968@googlemail.com>
Cc: bpf@vger.kernel.org, bpf@ietf.org, Dave Thaler <dthaler1968@gmail.com>
Subject: Re: [PATCH bpf-next] bpf, docs: Use RFC 2119 language for ISA requirements
Date: Mon, 20 May 2024 18:18:29 -0500	[thread overview]
Message-ID: <20240520231829.GC1116559@maniforge> (raw)
In-Reply-To: <20240517165855.4688-1-dthaler1968@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

On Fri, May 17, 2024 at 09:58:55AM -0700, Dave Thaler wrote:
> Per IETF convention and discussion at LSF/MM/BPF, use MUST etc.
> keywords as requested by IETF Area Director review.  Also as
> requested, indicate that documenting BTF is out of scope of this
> document and will be covered by a separate IETF specification.
> 
> Added paragraph about the terminology that is required IETF boilerplate
> and must be worded exactly as such.
> 
> Signed-off-by: Dave Thaler <dthaler1968@googlemail.com>

Acked-by: David Vernet <void@manifault.com>

We still have "may" in a couple of places, as in e.g.:

Note that there are two flavors of ``JA`` instructions. The ``JMP``
class permits a 16-bit jump offset specified by the 'offset' field,
whereas the ``JMP32`` class permits a 32-bit jump offset specified by
the 'imm' field. A > 16-bit conditional jump may be converted to a <
16-bit conditional jump plus a 32-bit unconditional jump.

Also in the "Helper functions" and "Maps" sections.

Do we need to fix those as well? Or are they considered semantically
different than how RFC 2119 would define the terms?

Thanks,
David

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: David Vernet <void@manifault.com>
To: Dave Thaler <dthaler1968@googlemail.com>
Cc: bpf@vger.kernel.org, bpf@ietf.org, Dave Thaler <dthaler1968@gmail.com>
Subject: [Bpf] Re: [PATCH bpf-next] bpf, docs: Use RFC 2119 language for ISA requirements
Date: Mon, 20 May 2024 18:18:29 -0500	[thread overview]
Message-ID: <20240520231829.GC1116559@maniforge> (raw)
Message-ID: <20240520231829.D_uzzfh_LtnB7BI5Tbp5sQgUkYSvabokWJhpipr26lo@z> (raw)
In-Reply-To: <20240517165855.4688-1-dthaler1968@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1151 bytes --]

On Fri, May 17, 2024 at 09:58:55AM -0700, Dave Thaler wrote:
> Per IETF convention and discussion at LSF/MM/BPF, use MUST etc.
> keywords as requested by IETF Area Director review.  Also as
> requested, indicate that documenting BTF is out of scope of this
> document and will be covered by a separate IETF specification.
> 
> Added paragraph about the terminology that is required IETF boilerplate
> and must be worded exactly as such.
> 
> Signed-off-by: Dave Thaler <dthaler1968@googlemail.com>

Acked-by: David Vernet <void@manifault.com>

We still have "may" in a couple of places, as in e.g.:

Note that there are two flavors of ``JA`` instructions. The ``JMP``
class permits a 16-bit jump offset specified by the 'offset' field,
whereas the ``JMP32`` class permits a 32-bit jump offset specified by
the 'imm' field. A > 16-bit conditional jump may be converted to a <
16-bit conditional jump plus a 32-bit unconditional jump.

Also in the "Helper functions" and "Maps" sections.

Do we need to fix those as well? Or are they considered semantically
different than how RFC 2119 would define the terms?

Thanks,
David

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 88 bytes --]

-- 
Bpf mailing list -- bpf@ietf.org
To unsubscribe send an email to bpf-leave@ietf.org

  parent reply	other threads:[~2024-05-20 23:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17 16:58 [PATCH bpf-next] bpf, docs: Use RFC 2119 language for ISA requirements Dave Thaler
2024-05-17 16:58 ` [Bpf] " Dave Thaler
2024-05-17 17:16 ` dthaler1968
2024-05-17 17:16   ` [Bpf] " dthaler1968=40googlemail.com
2024-05-20 23:18 ` David Vernet [this message]
2024-05-20 23:18   ` David Vernet
2024-05-20 23:43   ` dthaler1968
2024-05-20 23:43     ` [Bpf] " dthaler1968=40googlemail.com
2024-05-25 17:50 ` patchwork-bot+netdevbpf
2024-05-26  9:01 ` [Bpf] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240520231829.GC1116559@maniforge \
    --to=void@manifault.com \
    --cc=bpf@ietf.org \
    --cc=bpf@vger.kernel.org \
    --cc=dthaler1968@gmail.com \
    --cc=dthaler1968@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).