From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83BFC1DFFC for ; Sat, 25 May 2024 15:33:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716651217; cv=none; b=b5h5oUWN2Jatxp9lGiL6KkjYwLcS5XGRSEzBEc+G5grPrZo1wJQ/PJ6JHUr2W4+PbrQbfSbDYAqAP28/e1Cl7gaLNw4zO+ss4AA6FgrIDGxUBDDmDaKT2a7OVqWghgnp8nqvVp5ccKN+seQgGhacUt0wZw7llqYmdVb9eHaMwt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716651217; c=relaxed/simple; bh=9StCoyqXZRP9t0wnsp+Nrt2+XiTG1jKogib4mPXAEW4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=s4HIQfHXVHiFGEfsVDb86w+DTpdZUTMjWhkqJRYDRvzL/w1Dk7s0RYTGfZFqtd13cH/v+uu5twDmxEo83hg89mP/hlg80e7VEXqTytGpjK7e1GD5hO9QXQkk0igtVH62353RJ1B4HvZ5rsmGhnD4lSyqa44WmGNZnd7O52+J+Dc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com; spf=pass smtp.mailfrom=googlemail.com; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b=ciSMU7Pp; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=googlemail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="ciSMU7Pp" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1f44b59f8daso12645625ad.2 for ; Sat, 25 May 2024 08:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1716651215; x=1717256015; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WhgM3TzL1k+cJvnIJ9yiuydwQ2hP9//8jGA/WrlIoG8=; b=ciSMU7Pp4ma6hYlMSXst/3jll41c/Hro2KpD3l9fZZVTR8ucgI5/xXxBUulsaR01w7 0sBCIabUpilA3raQ/PhloP+KbnL8WYtcAAgITL0+OBifXHnQehJ9ImGzdaOr5aNFePeL sqQEgy2HCZHpCYPYai0TKuJBcoxgPn5tsu+sjAG47LX2U2TZvP6dMJBgoo9bACmvRr9Z shyucevkIIyoJW/zHk2XEFzrNuUby/OZYlQsrJPHRQrGPwxXMxh6JOjR9Dop4GIczoE/ m5+n2cwRDPhwVE5LFTdMXEWObJbcNFrIaNVf9otnR3lNxNmEQwTg7u+U+xN/fdE1yFax M7qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716651215; x=1717256015; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WhgM3TzL1k+cJvnIJ9yiuydwQ2hP9//8jGA/WrlIoG8=; b=JUYfP+FMnGVoemotxojrF5K9foaAPOe+RZyWpA+XKm6plLxY9yU+OOyU3vz/Lu3thY phxbzxl5aXguHktNeBCzRRLpJXFKWr46WdHFBd0rg9q/6dnm4/XifvLobjQtv6ur0z1a a2JxYeGXYxn2L3fB6rI1HWuADDdOMhkGCQcurbFj1QBxm1pMfzx4HHRRzapSAc7j1PgE 3BJQ97GoT/J0mci3rvUrKXz2cSRJ8Ps5xNOnngFBeAjmS+fBYklI9nKt5hND9w/MK/bh GFZ8KLK3frbhXlGxnRH5lQqBcEyfmfH1vc8U82uWipJIFb/HDFOVjEFMvBWRi+vpienZ egkg== X-Gm-Message-State: AOJu0YyAgXZpdv2dEDXb1qkMdFctnrzwlLbeb2aPCXPx0bemZBFRymWw AniY5d2N7xLE9Y7e5OaC1xvE9m06+4GDTpdQLPLgQoIHc0iEUPvMtDk7XILM X-Google-Smtp-Source: AGHT+IEmDQZqj1300++gHaFZYQuNrJSs/0y3Sdlv2EkEsUW2Ya+rfHEBXre6C5l12oDbAJ4B7Us7tA== X-Received: by 2002:a17:902:f68a:b0:1ea:cb6f:ee5b with SMTP id d9443c01a7336-1f44883876dmr63477225ad.38.1716651215310; Sat, 25 May 2024 08:33:35 -0700 (PDT) Received: from localhost.localdomain (c-67-170-74-237.hsd1.wa.comcast.net. [67.170.74.237]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c7cadf4sm31468335ad.109.2024.05.25.08.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 May 2024 08:33:34 -0700 (PDT) From: Dave Thaler X-Google-Original-From: Dave Thaler To: bpf@vger.kernel.org Cc: bpf@ietf.org, Dave Thaler Subject: [PATCH bpf-next] bpf, docs: Clarify call local offset Date: Sat, 25 May 2024 08:33:32 -0700 Message-Id: <20240525153332.21355-1-dthaler1968@gmail.com> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In the Jump instructions section it explains that the offset is "relative to the instruction following the jump instruction". But the program-local section confusingly said "referenced by offset from the call instruction, similar to JA". This patch updates that sentence with consistent wording, saying it's relative to the instruction following the call instruction. Signed-off-by: Dave Thaler --- Documentation/bpf/standardization/instruction-set.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst index 00c93eb42..6bb5ae7e4 100644 --- a/Documentation/bpf/standardization/instruction-set.rst +++ b/Documentation/bpf/standardization/instruction-set.rst @@ -520,7 +520,7 @@ identifies the helper name and type. Program-local functions ~~~~~~~~~~~~~~~~~~~~~~~ Program-local functions are functions exposed by the same BPF program as the -caller, and are referenced by offset from the call instruction, similar to +caller, and are referenced by offset from the instruction following the call instruction, similar to ``JA``. The offset is encoded in the 'imm' field of the call instruction. An ``EXIT`` within the program-local function will return to the caller. -- 2.40.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ietf.org (mail.ietf.org [50.223.129.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9E351DFFC for ; Sat, 25 May 2024 15:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=50.223.129.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716651233; cv=none; b=Ir6UX5pKmo4fKBmAR2KXXbnP8JY5CD+hAlkEdh66ukxpFq/0L0jH1I2kZxbSGCTM1ikSOER1A1zWyudGybVDLBB3OPPXKT7pfDc/AmQzslCdY/oX17Q/aWsgzGemOAG6k4EL/5oD5m6t+5jFwSKHAmpDwEk84aG+/67Ry3OzUaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716651233; c=relaxed/simple; bh=HmzY/e6/lrsYHcYzUC4KA8e0GCzuXfBjW5ubZ6NBYQw=; h=To:Date:Message-Id:MIME-Version:CC:Subject:Content-Type:From; b=BhIwEm4a0FYRhXjPz6Sby+s/MsWYkmU76JZUXtpBeK63mI4ZMKp13fKmsRHNk7nfGfhv7Bov6SmIjTmQsEfJNImWSg1vqnfcBgtv0XeNCdTiCDAOXEjvGhwZy++4ehqrfL94RwPeUqrhJNLaAQBayYGTDOkBx2h83WtBI7+pH8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dmarc.ietf.org; spf=pass smtp.mailfrom=ietf.org; dkim=pass (1024-bit key) header.d=ietf.org header.i=@ietf.org header.b=ZHAVbpWx; dkim=fail (1024-bit key) header.d=ietf.org header.i=@ietf.org header.b=lQmcOUqm reason="signature verification failed"; dkim=fail (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b=kYOd1CK6 reason="signature verification failed"; arc=none smtp.client-ip=50.223.129.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dmarc.ietf.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ietf.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ietf.org header.i=@ietf.org header.b="ZHAVbpWx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ietf.org header.i=@ietf.org header.b="lQmcOUqm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="kYOd1CK6" Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 7EB7BC14CEFD for ; Sat, 25 May 2024 08:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ietf.org; s=ietf1; t=1716651225; bh=HmzY/e6/lrsYHcYzUC4KA8e0GCzuXfBjW5ubZ6NBYQw=; h=To:Date:CC:Subject:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=ZHAVbpWxDrJWxDdyvXncv0dIoTL+olaSY1FTyywvoI/xpuYSYQi3wYgWLBrUE7Mbp 2ZlYifHr2ibEtCADlrkaW6AjighyuppQMEV81swHURRbhPFJVXf48sKn3yKCkOvoOb vgkUMWIP3i+YiBlO8tSn/kCk2DjxqgvO7ICWDGCs= Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 601E2C14CE3F for ; Sat, 25 May 2024 08:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ietf.org; s=ietf1; t=1716651225; bh=HmzY/e6/lrsYHcYzUC4KA8e0GCzuXfBjW5ubZ6NBYQw=; h=From:To:Date:CC:Subject:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe; b=lQmcOUqmlVoboa84upDN6KAVbZeQuXEDNtIplGknJFPEK3T7WP3C44YUJSi5uyM9r Idq0lhZ81+FJipi16CKC/K48zdeYwz8KeLZTuZm2w7LJlscnsuQd2PZF2oJzRXwTW6 wYP+dgWzNQwsYb3kPcXKUjPHOjvxtfKvBoWM1UBA= Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E4271C14F60F for ; Sat, 25 May 2024 08:33:39 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -6.845 X-Spam-Level: Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=googlemail.com Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V9LRHed56Diy for ; Sat, 25 May 2024 08:33:36 -0700 (PDT) Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 14642C14F604 for ; Sat, 25 May 2024 08:33:36 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1f082d92864so137453335ad.1 for ; Sat, 25 May 2024 08:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1716651215; x=1717256015; darn=ietf.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WhgM3TzL1k+cJvnIJ9yiuydwQ2hP9//8jGA/WrlIoG8=; b=kYOd1CK6gZm8lW3q5WdNLQmbys/YDbS111UuTv5TwMgCC4Bc2B6Xp4lz+zOmpmvvLf Esrv5Fo6PqWOyNtJQktFg8wDqCJd1axZmIdObg+2QcEcHFRDXgU5g7LazX10+z88JK9e mbzpDEa6fT2gbl1esE5gO4/eTevhjG1TsXVASJ/1XHsEY+jbj687xWsotSGdWyrQcNpQ Va5+LNFpKOYg04d43egsXRDXIAV08N1KsIICEVgdUP6ZdiiATZN9tMI1fHAFVd2BHTAT gAYWpTT8mHuyCR5aboXUM7wouJIkIyuOXqna5aTGQ5qOBiduQ1DtoED6N2h6mzVq0dPm eQrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716651215; x=1717256015; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WhgM3TzL1k+cJvnIJ9yiuydwQ2hP9//8jGA/WrlIoG8=; b=A85z0X6qtUuvD/hlnOWYhekGZedYRSuutRhGs3/UFu4/nsLAzmBjCBLzrulzAJXYQ9 mtN2zBe8D9znr7Ub/X5mSPxQ1kSUGP/Bke8acEGybVgrKcBBizc/Dk3X0yHyNub5RNcn hb8BH14xyNB1llwxRUvVFs+GDuQoE6aIfl973yg7nXNAsAuaSkf5eRBnuIvBiQUnAXqA 8xL9lJSNzO4anbcn3iqMclkyTZC8x9lNiPAoytdGlwAdMcKXmACqMgYLLzVLv9qcY9B4 8b9Bol6U2soLX4aL+L/P/GQLyzRIkJPbhiqroZ44PL5tsbVyhcHzBBRquswnfhWRFQCR 7Njw== X-Gm-Message-State: AOJu0YxQ7wsvhRWQKV0/N231YxJvtPYzYo2keQdDCSj2pa7P63PuLpDr vHToRwmCaxCA4Q9QjrIUllJs3BQPH2nSIIWWK0YXrrKjAUySDs37 X-Google-Smtp-Source: AGHT+IEmDQZqj1300++gHaFZYQuNrJSs/0y3Sdlv2EkEsUW2Ya+rfHEBXre6C5l12oDbAJ4B7Us7tA== X-Received: by 2002:a17:902:f68a:b0:1ea:cb6f:ee5b with SMTP id d9443c01a7336-1f44883876dmr63477225ad.38.1716651215310; Sat, 25 May 2024 08:33:35 -0700 (PDT) Received: from localhost.localdomain (c-67-170-74-237.hsd1.wa.comcast.net. [67.170.74.237]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c7cadf4sm31468335ad.109.2024.05.25.08.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 May 2024 08:33:34 -0700 (PDT) X-Google-Original-From: Dave Thaler To: bpf@vger.kernel.org Date: Sat, 25 May 2024 08:33:32 -0700 Message-ID: <20240525153332.21355-1-dthaler1968@gmail.com> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID-Hash: VXMPKSSYS7HYBLF75LAL46AVGP2TUFG7 X-Message-ID-Hash: VXMPKSSYS7HYBLF75LAL46AVGP2TUFG7 X-MailFrom: dthaler1968@googlemail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@ietf.org, Dave Thaler X-Mailman-Version: 3.3.9rc4 Precedence: list Subject: =?utf-8?q?=5BBpf=5D_=5BPATCH_bpf-next=5D_bpf=2C_docs=3A_Clarify_call_local_o?= =?utf-8?q?ffset?= Archived-At: List-Archive: List-Help: List-Owner: List-Post: X-Mailman-Copy: yes Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 X-Original-From: Dave Thaler From: Dave Thaler Message-ID: <20240525153332.fmoVLTcWZclXaebbgUESBjbM8c58biV1F_-KQBWl0EI@z> SW4gdGhlIEp1bXAgaW5zdHJ1Y3Rpb25zIHNlY3Rpb24gaXQgZXhwbGFpbnMgdGhhdCB0aGUgb2Zm c2V0IGlzDQoicmVsYXRpdmUgdG8gdGhlIGluc3RydWN0aW9uIGZvbGxvd2luZyB0aGUganVtcCBp bnN0cnVjdGlvbiIuDQpCdXQgdGhlIHByb2dyYW0tbG9jYWwgc2VjdGlvbiBjb25mdXNpbmdseSBz YWlkICJyZWZlcmVuY2VkIGJ5DQpvZmZzZXQgZnJvbSB0aGUgY2FsbCBpbnN0cnVjdGlvbiwgc2lt aWxhciB0byBKQSIuDQoNClRoaXMgcGF0Y2ggdXBkYXRlcyB0aGF0IHNlbnRlbmNlIHdpdGggY29u c2lzdGVudCB3b3JkaW5nLCBzYXlpbmcNCml0J3MgcmVsYXRpdmUgdG8gdGhlIGluc3RydWN0aW9u IGZvbGxvd2luZyB0aGUgY2FsbCBpbnN0cnVjdGlvbi4NCg0KU2lnbmVkLW9mZi1ieTogRGF2ZSBU aGFsZXIgPGR0aGFsZXIxOTY4QGdtYWlsLmNvbT4NCi0tLQ0KIERvY3VtZW50YXRpb24vYnBmL3N0 YW5kYXJkaXphdGlvbi9pbnN0cnVjdGlvbi1zZXQucnN0IHwgMiArLQ0KIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KDQpkaWZmIC0tZ2l0IGEvRG9jdW1lbnRh dGlvbi9icGYvc3RhbmRhcmRpemF0aW9uL2luc3RydWN0aW9uLXNldC5yc3QgYi9Eb2N1bWVudGF0 aW9uL2JwZi9zdGFuZGFyZGl6YXRpb24vaW5zdHJ1Y3Rpb24tc2V0LnJzdA0KaW5kZXggMDBjOTNl YjQyLi42YmI1YWU3ZTQgMTAwNjQ0DQotLS0gYS9Eb2N1bWVudGF0aW9uL2JwZi9zdGFuZGFyZGl6 YXRpb24vaW5zdHJ1Y3Rpb24tc2V0LnJzdA0KKysrIGIvRG9jdW1lbnRhdGlvbi9icGYvc3RhbmRh cmRpemF0aW9uL2luc3RydWN0aW9uLXNldC5yc3QNCkBAIC01MjAsNyArNTIwLDcgQEAgaWRlbnRp ZmllcyB0aGUgaGVscGVyIG5hbWUgYW5kIHR5cGUuDQogUHJvZ3JhbS1sb2NhbCBmdW5jdGlvbnMN CiB+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fg0KIFByb2dyYW0tbG9jYWwgZnVuY3Rpb25zIGFyZSBm dW5jdGlvbnMgZXhwb3NlZCBieSB0aGUgc2FtZSBCUEYgcHJvZ3JhbSBhcyB0aGUNCi1jYWxsZXIs IGFuZCBhcmUgcmVmZXJlbmNlZCBieSBvZmZzZXQgZnJvbSB0aGUgY2FsbCBpbnN0cnVjdGlvbiwg c2ltaWxhciB0bw0KK2NhbGxlciwgYW5kIGFyZSByZWZlcmVuY2VkIGJ5IG9mZnNldCBmcm9tIHRo ZSBpbnN0cnVjdGlvbiBmb2xsb3dpbmcgdGhlIGNhbGwgaW5zdHJ1Y3Rpb24sIHNpbWlsYXIgdG8N CiBgYEpBYGAuICBUaGUgb2Zmc2V0IGlzIGVuY29kZWQgaW4gdGhlICdpbW0nIGZpZWxkIG9mIHRo ZSBjYWxsIGluc3RydWN0aW9uLg0KIEFuIGBgRVhJVGBgIHdpdGhpbiB0aGUgcHJvZ3JhbS1sb2Nh bCBmdW5jdGlvbiB3aWxsIHJldHVybiB0byB0aGUgY2FsbGVyLg0KIA0KLS0gDQoyLjQwLjENCg0K LS0gCkJwZiBtYWlsaW5nIGxpc3QgLS0gYnBmQGlldGYub3JnClRvIHVuc3Vic2NyaWJlIHNlbmQg YW4gZW1haWwgdG8gYnBmLWxlYXZlQGlldGYub3JnCg==