From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Viktor Malik <vmalik@redhat.com>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] bpf: Use an UNUSED id for bpf_session_cookie without FPROBE
Date: Fri, 31 May 2024 09:15:57 +0200 [thread overview]
Message-ID: <20240531071557.MvfIqkn7@linutronix.de> (raw)
In-Reply-To: <ZleDQSK4TgJLJDUl@krava>
On 2024-05-29 21:34:25 [+0200], Jiri Olsa wrote:
> > > +#ifdef CONFIG_FPROBE
> > > BTF_ID(func, bpf_session_cookie)
> > > +#else
> > > +BTF_ID_UNUSED
> > > +#endif
> >
> > Instead of this fix..
> > Jiri,
> > maybe remove ifdef CONFIG_FPROBE hiding of this kfunc
> > in kernel/tace/bpf_trace.c ?
> > The less ifdef-s the better. imo
>
> yes, that seems to work
>
> Sebastian, do you want to send it as v2 or should I post it?
Now that I look again, ifdef CONFIG_FPROBE isn't enough it requires
additionally CONFIG_UPROBE_EVENTS.
So the suggested snippet does not work if CONFIG_UPROBE_EVENTS is not
enabled.
> thanks,
> jirka
Sebastian
prev parent reply other threads:[~2024-05-31 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 12:44 [PATCH] bpf: Use an UNUSED id for bpf_session_cookie without FPROBE Sebastian Andrzej Siewior
2024-05-29 16:18 ` Alexei Starovoitov
2024-05-29 19:34 ` Jiri Olsa
2024-05-31 7:15 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240531071557.MvfIqkn7@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=mhiramat@kernel.org \
--cc=olsajiri@gmail.com \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=vmalik@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox