From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2C0B19EEAC for ; Fri, 7 Jun 2024 14:52:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717771972; cv=none; b=U9kAf5h3hGmm1dGvJ7UyTDktEHv3nMMFnjsneXW00zvxxiGcWK70HVQdnLfpcK5ja1G60NJMeGU/QvPjO0Or8OgA/q5WJTI0F+OEt9mS1bLTs+v7vf2oKkA9bLSbIgcbdn07/+emJgtIUvcjal2Vc0bygXqNpReDuVU4Gu/FDh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717771972; c=relaxed/simple; bh=lRtTAdTXNw3RVPrpvvNKKuuzE413bhtwKVpiQVvurek=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uPFstxpnjQbTwYrTis4D5b+tP5Aa8XjFWwQo+H9a+whJSxKWOeTWWKt80xaeXF4hx4RWITnp2VaLeJn0wITFLSKC4JSLVTLql3U7ua5fVcpYaNZ8D+/rN8d+qNyW97iwb3gBjvBz2VMPlSiIB/F55UrnePL57uY4ImhzJA7YpDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=fPBjriGS; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="fPBjriGS" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7951713ba08so181039385a.1 for ; Fri, 07 Jun 2024 07:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1717771969; x=1718376769; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=be9t9+ReZ6YBtow20QbHH2FmkX+nC7rbtPeGa2mS4as=; b=fPBjriGS2HqU+xJrI5erAaLintSF4U9+wSPhbi+MGoW9UhLCGzGgKCqGTyQRdut3DQ X1ji8r0wiFaBYsBQzz269jfKPz4DBspcZ60BYFljXwI16KwEMF2oypjK2qSqis2xevit 13xGLJ3UAesNbUh8n8wJjjFHpiIS91s5D2AHQLAL5QAXKemSK+3vJJxtYb9t8Qi4BtXo pKFKi8NlrZaLt11foQWGlPz6NpqkCXL4cLth2jY1zzA8+uZ0WYaX+6DLurkj349g+JBw kswGGZGoT4rgzXE+D6M8V+WNOHPsbiB3aZfGiPfcbrsrqDsMvHvye9xMxMkd3c8Dqzgh gUSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717771969; x=1718376769; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=be9t9+ReZ6YBtow20QbHH2FmkX+nC7rbtPeGa2mS4as=; b=cZUQg41xmYS390KoQeoS3AyeAYZh4lXDfWO+Z5lrsVMbIErQ6xc1FTV4cSD7Dr81BG TdzqSyfaamTdL4jlWCSRR4NlhUYxBSrQ379TfrrjWftvB8VB7bTFDufllnOGOwaiJWcD 1WYPcxxXMSxh7wr6Q34r51Y+h6jes460J4ICV7hOVjeYSweI3FEY5XREb4c8T6wQAz3e ZrAC/aU+DLE50SxaWh7vogxUMIqlN/jEkyBNhVNpb09Mhl7261nyf3AeNGa9piAKvBDi is9/i8WtVFG6N5+9uSeQyAZ6VjnFecDvsxa/ZIr5HhQUGlQNUprdXhv5ZjTsWze1H9y5 MeFA== X-Forwarded-Encrypted: i=1; AJvYcCUMTThfUqjrDQnSULBSJTMBw2BXaDLkruGcf0bBy4XPi8/JYMLeTWbFvw7/g76Pt67EqD7ACy3HhvJeFbjC/GAD43/n X-Gm-Message-State: AOJu0Yy3ZPo0EBNMh+bII+THifomlMBm/PeyX3rnXpP4bFEvq60Naz79 0qC4jzfc8zIlKasjo2eXU4mnicCHSOctORvH7zLpZ125kAoiOkkVIE+GBoOU85Y= X-Google-Smtp-Source: AGHT+IEol1YR1WI0zC3A5eIuWJjKcIm2ZGRprGfgrv26PYx2gMqkRphUST2lY2DmLHNeG4xW82MRzw== X-Received: by 2002:a05:620a:31a8:b0:795:4e67:1ef5 with SMTP id af79cd13be357-7954e672231mr106304685a.11.1717771968557; Fri, 07 Jun 2024 07:52:48 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79532870231sm173090885a.60.2024.06.07.07.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 07:52:48 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1sFaxT-00HGBa-Cf; Fri, 07 Jun 2024 11:52:47 -0300 Date: Fri, 7 Jun 2024 11:52:47 -0300 From: Jason Gunthorpe To: David Ahern Cc: Pavel Begunkov , Mina Almasry , Christoph Hellwig , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arch@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Andreas Larsson , Jesper Dangaard Brouer , Ilias Apalodimas , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Steffen Klassert , Herbert Xu , Willem de Bruijn , Shuah Khan , Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , David Wei , Yunsheng Lin , Shailend Chand , Harshitha Ramamurthy , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi Subject: Re: [PATCH net-next v10 02/14] net: page_pool: create hooks for custom page providers Message-ID: <20240607145247.GG791043@ziepe.ca> References: <20240530201616.1316526-1-almasrymina@google.com> <20240530201616.1316526-3-almasrymina@google.com> <5aee4bba-ca65-443c-bd78-e5599b814a13@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jun 07, 2024 at 08:27:29AM -0600, David Ahern wrote: > On 6/7/24 7:42 AM, Pavel Begunkov wrote: > > I haven't seen any arguments against from the (net) maintainers so > > far. Nor I see any objection against callbacks from them (considering > > that either option adds an if). > > I have said before I do not understand why the dmabuf paradigm is not > sufficient for both device memory and host memory. A less than ideal > control path to put hostmem in a dmabuf wrapper vs extra checks and > changes in the datapath. The former should always be preferred. I think Pavel explained this - his project is principally to replace the lifetime policy of pages in the data plane. He wants to change when a page is considered available for re-allocation because userspace may continue to use the page after the netstack thinks it is done with it. It sounds like having a different source of the pages is the less important part. IMHO it seems to compose poorly if you can only use the io_uring lifecycle model with io_uring registered memory, and not with DMABUF memory registered through Mina's mechanism. Jason