From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5889F4EB5E for ; Wed, 12 Jun 2024 23:44:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718235893; cv=none; b=lhU/wLGQGfv4Cs0KRnT41cysMTVTanOftW+PBtSpk/jr/TC2UwbkpTta4pjiqy/8fPyM577tlCJ36qUcA6pi7Sp2Bk2ORSVWLaILtt7ZtfpicSw92AiMn+2SvY3BpsgggdXPYrFR3KyAdH0DuqWbSscVbwit1+Fv+uMfBe3jxo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718235893; c=relaxed/simple; bh=LQb3o2/CP5JSK8KAyQba5WkdaHhdXZYvdSrm+JnIPLk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K7EORbgU8wFoEAIZdWutEwZ0d+9YBaQ4R5I6TnGYpVYErgqDSqAmy2WdVjxVJ6UwZCGK+G2fhWIiD6dVrxv/zqe7p2rB+rzCk9qDihmcY8EgxApk+uJ7BuCSV6fQ1JqBdu8DjJfv3VSV+G9biybKjWC6OLWuTR99TN2zLQWTBFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e7RTCU+l; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e7RTCU+l" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718235891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h1VosMQ3bFESuAWLh6SDqxXuOvd8Mst+9B84qG9NSYg=; b=e7RTCU+lGP3l388/1GgEY+J9ar0WROLfo2BnbA7m8JXGL3PyQK4GyTWv60XfSxKwbRnder iebJEw8c3Cck8/7gd59M07kolMTV0bdR8DZ/9R13bY63nw5P7hEByP99usMfpG+RgHiC10 D83rgffA+aKKpQVCB5LBHPi/Ua1Oncc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-iSygYzUYPZmykRtYokZ4Rw-1; Wed, 12 Jun 2024 19:44:49 -0400 X-MC-Unique: iSygYzUYPZmykRtYokZ4Rw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-35f1230659bso454950f8f.1 for ; Wed, 12 Jun 2024 16:44:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718235888; x=1718840688; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h1VosMQ3bFESuAWLh6SDqxXuOvd8Mst+9B84qG9NSYg=; b=RyvbVrPwDD5aAwZI0IbYxMsnj9xeRqrxU2qdEHmCMOOJ+E4MANYfnYwhiMcczdyons B9SZ1kWofQFUzsHaP1a4U4tp6O+RE7SAKI5gkY++4+t3/ODT+NkYhCQuyKQPUxvhEdcy od/8GMe/mQwkVoQATJNaFcEqhUO7r+TepuTsa04UzOqWcNmILXQ5aksyFRzOPI8+z7v3 LMhrDb/3r04R8I3S2fW8uYxYylzytwHw4pbEWc8DlBf78bJoD9ORLYNji8viTFYTX36s 9OOLkgF2nRU8PLsLhe32qainAvXWtgchSsxP/xW1G5S4/inhlaHY694P3Ufq2NBt/qFl 2Eag== X-Forwarded-Encrypted: i=1; AJvYcCV+kMKh/rdiky1H62DoYmtVigLNQ3CctLgPKINKVOPtJkfnGwSC2zEehwsL1DqsDHxj0xEe7H2LvjW8x2ftHUiMUGOd X-Gm-Message-State: AOJu0YyLuGBQiEqUBz/m/xG98kgObpoRKng3/k1bfoEgk71NMlUdD+j4 MY9QELbYIvyGZN0M42G5y4Hpz7YzHBBwk/WvSRC6YPF/1xXG57Hd261+CdBsqbMdiaMSCCvCmsy tmBmpZG5c/YepWe456oani1Rz9TbKY1Z7VdlZKOjlUWvKqofRmQ== X-Received: by 2002:a05:6000:2c4:b0:35f:1f3c:b632 with SMTP id ffacd0b85a97d-35fdf779b4dmr3084389f8f.12.1718235888517; Wed, 12 Jun 2024 16:44:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzTM0DuELFcd6K5W5zmF+NgyZEAXmKiPtBN7iRmrfadHH+oMGDf2fEtoNYfG4eSc3SnCV0pw== X-Received: by 2002:a05:6000:2c4:b0:35f:1f3c:b632 with SMTP id ffacd0b85a97d-35fdf779b4dmr3084379f8f.12.1718235888065; Wed, 12 Jun 2024 16:44:48 -0700 (PDT) Received: from redhat.com ([2a02:14f:176:94c5:b48b:41a4:81c0:f1c8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3607509c8c2sm119131f8f.31.2024.06.12.16.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 16:44:47 -0700 (PDT) Date: Wed, 12 Jun 2024 19:44:41 -0400 From: "Michael S. Tsirkin" To: Jakub Kicinski Cc: Xuan Zhuo , netdev@vger.kernel.org, Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , "David S. Miller" , Eric Dumazet , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , virtualization@lists.linux.dev, bpf@vger.kernel.org Subject: Re: [PATCH net-next v4 11/15] virtio_net: xsk: tx: support xmit xsk buffer Message-ID: <20240612194425-mutt-send-email-mst@kernel.org> References: <20240611114147.31320-1-xuanzhuo@linux.alibaba.com> <20240611114147.31320-12-xuanzhuo@linux.alibaba.com> <20240612162505.2fa3e645@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240612162505.2fa3e645@kernel.org> On Wed, Jun 12, 2024 at 04:25:05PM -0700, Jakub Kicinski wrote: > On Tue, 11 Jun 2024 19:41:43 +0800 Xuan Zhuo wrote: > > @@ -534,10 +534,13 @@ enum virtnet_xmit_type { > > VIRTNET_XMIT_TYPE_SKB, > > VIRTNET_XMIT_TYPE_XDP, > > VIRTNET_XMIT_TYPE_DMA, > > + VIRTNET_XMIT_TYPE_XSK, > > Again, would be great to avoid the transient warning (if it can be done > cleanly): > > drivers/net/virtio_net.c:5806:9: warning: enumeration value ‘VIRTNET_XMIT_TYPE_XSK’ not handled in switch [-Wswitch] > 5806 | switch (virtnet_xmit_ptr_strip(&buf)) { > | ^~~~~~ yea just squashing is usually enough. -- MST