From: Vadim Fedorenko <vadfed@meta.com>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Martin KaFai Lau <martin.lau@linux.dev>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>
Cc: <bpf@vger.kernel.org>, Vadim Fedorenko <vadfed@meta.com>,
"Alexei Starovoitov" <ast@kernel.org>,
Mykola Lysenko <mykolal@fb.com>,
"Daniel Borkmann" <daniel@iogearbox.net>
Subject: [PATCH RESEND bpf-next v3 0/5] bpf: make trusted args nullable
Date: Thu, 13 Jun 2024 14:18:12 -0700 [thread overview]
Message-ID: <20240613211817.1551967-1-vadfed@meta.com> (raw)
Current verifier checks for the arg to be nullable after checking for
certain pointer types. It prevents programs to pass NULL to kfunc args
even if they are marked as nullable. This patchset adjusts verifier and
changes bpf crypto kfuncs to allow null for IV parameter which is
optional for some ciphers. Benchmark shows ~4% improvements when there
is no need to initialise 0-sized dynptr.
v3:
- add special selftest for nullable parameters
v2:
- adjust kdoc accordingly
Vadim Fedorenko (5):
bpf: verifier: make kfuncs args nullalble
bpf: crypto: make state and IV dynptr nullable
selftests: bpf: crypto: use NULL instead of 0-sized dynptr
selftests: bpf: crypto: adjust bench to use nullable IV
selftests: bpf: add testmod kfunc for nullable params
kernel/bpf/crypto.c | 26 +++++------
kernel/bpf/verifier.c | 6 +--
.../selftests/bpf/bpf_testmod/bpf_testmod.c | 6 +++
.../bpf/bpf_testmod/bpf_testmod_kfunc.h | 1 +
.../bpf/prog_tests/kfunc_param_nullable.c | 11 +++++
.../selftests/bpf/progs/crypto_bench.c | 10 ++---
.../selftests/bpf/progs/crypto_sanity.c | 16 ++-----
.../bpf/progs/test_kfunc_param_nullable.c | 43 +++++++++++++++++++
8 files changed, 85 insertions(+), 34 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/kfunc_param_nullable.c
create mode 100644 tools/testing/selftests/bpf/progs/test_kfunc_param_nullable.c
--
2.43.0
next reply other threads:[~2024-06-13 21:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 21:18 Vadim Fedorenko [this message]
2024-06-13 21:18 ` [PATCH RESEND bpf-next v3 1/5] bpf: verifier: make kfuncs args nullalble Vadim Fedorenko
2024-06-13 21:18 ` [PATCH RESEND bpf-next v3 2/5] bpf: crypto: make state and IV dynptr nullable Vadim Fedorenko
2024-06-13 21:18 ` [PATCH RESEND bpf-next v3 3/5] selftests: bpf: crypto: use NULL instead of 0-sized dynptr Vadim Fedorenko
2024-06-13 21:18 ` [PATCH RESEND bpf-next v3 4/5] selftests: bpf: crypto: adjust bench to use nullable IV Vadim Fedorenko
2024-06-13 21:18 ` [PATCH RESEND bpf-next v3 5/5] selftests: bpf: add testmod kfunc for nullable params Vadim Fedorenko
2024-06-13 23:40 ` [PATCH RESEND bpf-next v3 0/5] bpf: make trusted args nullable patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613211817.1551967-1-vadfed@meta.com \
--to=vadfed@meta.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox