From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7886C36C; Tue, 2 Jul 2024 00:02:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719878528; cv=none; b=cwU/UEFtYSKtP+2MC5yMK7DM9CqnSwadrw3blvXu0KQ87QAM3KKP1tAEZpZeI0iJUB8hokmcCAzCyM2MlUsyriGy/ByhztHfxtb0tOScYy8msmYdej9qX66VCeugKVhOFHUYC37BbrTp0XHR09416fffwQ8tPTe2Xvsytz/nenQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719878528; c=relaxed/simple; bh=Midxuz2nY9NJvcn5v3bgVN2AzPPMKajP3rum1jiNEFY=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=U6otFbMrp4aYjb9AFcS9cJNQlMs9ftjbiEO8uZ4YtAf+tNu22MkEKmKDIEKX0Y2O/mYedD/264yJPecIbPVzAnoKqqoCDzXTPhkMMwIjgLdmNE6KCyuz9n3Cv3YJzdqGo74B/QGaqJU7+1OwadCPe9Pn0/0W10TsXSJbFZtZ3QE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uUrkfwUl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uUrkfwUl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A1CFC116B1; Tue, 2 Jul 2024 00:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719878528; bh=Midxuz2nY9NJvcn5v3bgVN2AzPPMKajP3rum1jiNEFY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uUrkfwUlRSgR+4TG2TqSfX8K/wl6BMNwYXIsILx9EdSjEyHqGZbferwZscXk3sQQC OvgM9GopMas3t5xkXtSmNAHK2HESdk4zEzDS+csLTr+yDi/MiTtad+7d7zceY80kkv 5+TMUr6kQYQ8295x9iaDO7JpJqA00WIWj7U1LMkFzD1bDPYAS7YyJMZM8tWd7zrVdZ dAL9Yu0zwEi1GnkboN6mVkepvTWurycB+EH1/tHGPVe2Zf3PaLjqsKCES4YtxO/3il UsNOJlU03eqj8Q/CQYL3u3/DLeWNqcg5tUFNuOzp5grXfY4VStIcPemu9mSQMAcQW4 4sQf7VfVsIc7Q== Date: Tue, 2 Jul 2024 09:02:02 +0900 From: Masami Hiramatsu (Google) To: Mathieu Desnoyers Cc: Steven Rostedt , linux-kernel@vger.kernel.org, Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , bpf@vger.kernel.org, Joel Fernandes , Michael Jeanson Subject: Re: [PATCH v5 6/8] tracing/bpf-trace: Add support for faultable tracepoints Message-Id: <20240702090202.bc000b44890fe16d9b757b40@kernel.org> In-Reply-To: <20240626185941.68420-7-mathieu.desnoyers@efficios.com> References: <20240626185941.68420-1-mathieu.desnoyers@efficios.com> <20240626185941.68420-7-mathieu.desnoyers@efficios.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 26 Jun 2024 14:59:39 -0400 Mathieu Desnoyers wrote: > @@ -2443,9 +2443,15 @@ static int __bpf_probe_register(struct bpf_raw_event_map *btp, struct bpf_prog * > if (prog->aux->max_tp_access > btp->writable_size) > return -EINVAL; > > - return tracepoint_probe_register_prio_flags(tp, (void *)btp->bpf_func, > - prog, TRACEPOINT_DEFAULT_PRIO, > - TRACEPOINT_MAY_EXIST); > + if (tp->flags & TRACEPOINT_MAY_FAULT) { > + return tracepoint_probe_register_prio_flags(tp, (void *)btp->bpf_func, > + prog, TRACEPOINT_DEFAULT_PRIO, > + TRACEPOINT_MAY_EXIST | TRACEPOINT_MAY_FAULT); > + } else { > + return tracepoint_probe_register_prio_flags(tp, (void *)btp->bpf_func, > + prog, TRACEPOINT_DEFAULT_PRIO, > + TRACEPOINT_MAY_EXIST); > + } nit: you can also just pass the flag directly, return tracepoint_probe_register_prio_flags(tp, (void *)btp->bpf_func, prog, TRACEPOINT_DEFAULT_PRIO, TRACEPOINT_MAY_EXIST | (tp->flags & TRACEPOINT_MAY_FAULT)); But others looks good to me. Reviewed-by: Masami Hiramatsu (Google) Thank you, -- Masami Hiramatsu (Google)