From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <netdev@vger.kernel.org>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
<magnus.karlsson@intel.com>, <aleksander.lobakin@intel.com>,
<ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <bpf@vger.kernel.org>,
Shannon Nelson <shannon.nelson@amd.com>,
Chandan Kumar Rout <chandanx.rout@intel.com>
Subject: Re: [PATCH net 8/8] ice: xsk: fix txq interrupt mapping
Date: Wed, 10 Jul 2024 11:22:00 +0530 [thread overview]
Message-ID: <20240710055200.GA3213393@maili.marvell.com> (raw)
On 2024-07-09 at 03:44:14, Tony Nguyen (anthony.l.nguyen@intel.com) wrote:
> From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>
> {
> u16 reg_idx = q_vector->reg_idx;
> struct ice_pf *pf = vsi->back;
> struct ice_hw *hw = &pf->hw;
> - struct ice_tx_ring *tx_ring;
> - struct ice_rx_ring *rx_ring;
> + int q, _qid = qid;
>
> ice_cfg_itr(hw, q_vector);
>
> - ice_for_each_tx_ring(tx_ring, q_vector->tx)
> - ice_cfg_txq_interrupt(vsi, tx_ring->reg_idx, reg_idx,
> - q_vector->tx.itr_idx);
> + for (q = 0; q < q_vector->num_ring_tx; q++) {
> + ice_cfg_txq_interrupt(vsi, _qid, reg_idx, q_vector->tx.itr_idx);
> + _qid++;
> + }
nit: why we need a new variable just for "for" loop ? qid + q wont suffice ?
>
next reply other threads:[~2024-07-10 5:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 5:52 Ratheesh Kannoth [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-07-08 22:14 [PATCH net 0/8][pull request] ice: fix AF_XDP ZC timeout and concurrency issues Tony Nguyen
2024-07-08 22:14 ` [PATCH net 8/8] ice: xsk: fix txq interrupt mapping Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710055200.GA3213393@maili.marvell.com \
--to=rkannoth@marvell.com \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chandanx.rout@intel.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox