Re: [PATCH v4 1/20] lsm: Refactor return value of LSM hook vm_enough_memory

Paul Moore
2024-07-19T02:08:01Z

On Jul 11, 2024 Xu Kuohai <xukuohai@huaweicloud.com> wrote:
>
> To be consistent with most LSM hooks, convert the return value of
> hook vm_enough_memory to 0 or a negative error code.
>
> Before:
> - Hook vm_enough_memory returns 1 if permission is granted, 0 if not.
> - LSM_RET_DEFAULT(vm_enough_memory_mm) is 1.
>
> After:
> - Hook vm_enough_memory reutrns 0 if permission is granted, negative
> error code if not.
> - LSM_RET_DEFAULT(vm_enough_memory_mm) is 0.
>
> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
> ---
> include/linux/lsm_hook_defs.h | 2 +-
> include/linux/security.h | 2 +-
> security/commoncap.c | 11 +++--------
> security/security.c | 11 +++++------
> security/selinux/hooks.c | 15 ++++-----------
> 5 files changed, 14 insertions(+), 27 deletions(-)

A nice improvement, thank you!

--
paul-moore.com