From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
maciej.fijalkowski@intel.com, magnus.karlsson@intel.com,
aleksander.lobakin@intel.com, ast@kernel.org,
daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
bpf@vger.kernel.org
Subject: [PATCH net v2 0/8][pull request] ice: fix AF_XDP ZC timeout and concurrency issues
Date: Mon, 29 Jul 2024 13:07:06 -0700 [thread overview]
Message-ID: <20240729200716.681496-1-anthony.l.nguyen@intel.com> (raw)
Maciej Fijalkowski says:
Changes included in this patchset address an issue that customer has
been facing when AF_XDP ZC Tx sockets were used in combination with flow
control and regular Tx traffic.
After executing:
ethtool --set-priv-flags $dev link-down-on-close on
ethtool -A $dev rx on tx on
launching multiple ZC Tx sockets on $dev + pinging remote interface (so
that regular Tx traffic is present) and then going through down/up of
$dev, Tx timeout occurred and then most of the time ice driver was unable
to recover from that state.
These patches combined together solve the described above issue on
customer side. Main focus here is to forbid producing Tx descriptors when
either carrier is not yet initialized or process of bringing interface
down has already started.
v2:
* in patch 6, use a single READ_ONCE against xsk_pool within napi [Jakub]
v1: https://lore.kernel.org/netdev/20240708221416.625850-1-anthony.l.nguyen@intel.com/
---
Olek,
we decided not to check IFF_UP as you initially suggested. Reason is
that when link goes down netif_running() has broader scope than IFF_UP
being set as the former (the __LINK_STATE_START bit) is cleared earlier
in the core.
The following are changes since commit 039564d2fd37b122ec0d268e2ee6334e7169e225:
Merge branch 'mptcp-endpoint-readd-fixes' into main
and are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue 100GbE
Maciej Fijalkowski (7):
ice: don't busy wait for Rx queue disable in ice_qp_dis()
ice: replace synchronize_rcu with synchronize_net
ice: modify error handling when setting XSK pool in ndo_bpf
ice: toggle netif_carrier when setting up XSK pool
ice: improve updating ice_{t,r}x_ring::xsk_pool
ice: add missing WRITE_ONCE when clearing ice_rx_ring::xdp_prog
ice: xsk: fix txq interrupt mapping
Michal Kubiak (1):
ice: respect netif readiness in AF_XDP ZC related ndo's
drivers/net/ethernet/intel/ice/ice.h | 11 +-
drivers/net/ethernet/intel/ice/ice_base.c | 4 +-
drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
drivers/net/ethernet/intel/ice/ice_txrx.c | 10 +-
drivers/net/ethernet/intel/ice/ice_xsk.c | 184 +++++++++++++---------
drivers/net/ethernet/intel/ice/ice_xsk.h | 14 +-
6 files changed, 135 insertions(+), 90 deletions(-)
--
2.42.0
next reply other threads:[~2024-07-29 20:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 20:07 Tony Nguyen [this message]
2024-07-29 20:07 ` [PATCH net v2 1/8] ice: respect netif readiness in AF_XDP ZC related ndo's Tony Nguyen
2024-07-29 20:07 ` [PATCH net v2 2/8] ice: don't busy wait for Rx queue disable in ice_qp_dis() Tony Nguyen
2024-07-29 20:07 ` [PATCH net v2 3/8] ice: replace synchronize_rcu with synchronize_net Tony Nguyen
2024-07-29 20:07 ` [PATCH net v2 4/8] ice: modify error handling when setting XSK pool in ndo_bpf Tony Nguyen
2024-07-29 20:07 ` [PATCH net v2 5/8] ice: toggle netif_carrier when setting up XSK pool Tony Nguyen
2024-07-29 20:07 ` [PATCH net v2 6/8] ice: improve updating ice_{t,r}x_ring::xsk_pool Tony Nguyen
2024-07-29 20:07 ` [PATCH net v2 7/8] ice: add missing WRITE_ONCE when clearing ice_rx_ring::xdp_prog Tony Nguyen
2024-07-29 20:07 ` [PATCH net v2 8/8] ice: xsk: fix txq interrupt mapping Tony Nguyen
2024-07-31 2:00 ` [PATCH net v2 0/8][pull request] ice: fix AF_XDP ZC timeout and concurrency issues patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729200716.681496-1-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox