From: Oleg Nesterov <oleg@redhat.com>
To: Alexey Gladkov <legion@kernel.org>
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
linux-kbuild@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH v3] bpf: Remove custom build rule
Date: Wed, 28 Aug 2024 21:14:45 +0200 [thread overview]
Message-ID: <20240828191444.GA3806@redhat.com> (raw)
In-Reply-To: <20240828181028.4166334-1-legion@kernel.org>
I know nothing about Kbuild, I can only confirm that this patch fixes the
problem I encountered in practice.
On 08/28, Alexey Gladkov wrote:
>
> $ touch kernel/bpf/core.c
> $ make C=2 CHECK=true kernel/bpf/core.o
>
> Outputs:
>
> CHECK scripts/mod/empty.c
> CALL scripts/checksyscalls.sh
> DESCEND objtool
> INSTALL libsubcmd_headers
> CC kernel/bpf/core.o
>
> As can be seen the compilation is done, but CHECK is not executed.
And after that
$ make C=2 CHECK=true kernel/bpf/core.o
CHECK scripts/mod/empty.c
CALL scripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CHECK is also not executed.
compare with, for example,
$ touch kernel/trace/trace.c
$ make C=2 CHECK=true kernel/trace/trace.o
CHECK scripts/mod/empty.c
CALL scripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC kernel/trace/trace.o
CHECK kernel/trace/trace.c
$ make C=2 CHECK=true kernel/trace/trace.o
CHECK scripts/mod/empty.c
CALL scripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CHECK kernel/trace/trace.c
Tested-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2024-08-28 19:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 15:25 [PATCH v1] bpf: Add missing force_checksrc macro Alexey Gladkov
2024-08-28 16:32 ` Masahiro Yamada
2024-08-28 17:06 ` [PATCH v2] bpf: Remove custom build rule Alexey Gladkov
2024-08-28 17:22 ` Masahiro Yamada
2024-08-28 17:49 ` Alexey Gladkov
2024-08-28 18:10 ` [PATCH v3] " Alexey Gladkov
2024-08-28 18:32 ` Masahiro Yamada
2024-08-28 19:14 ` Oleg Nesterov [this message]
2024-08-29 10:12 ` Alan Maguire
2024-08-29 19:24 ` Alexei Starovoitov
2024-08-30 7:43 ` [PATCH v4] " Alexey Gladkov
2024-08-30 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828191444.GA3806@redhat.com \
--to=oleg@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=legion@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox