Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text

Mike Rapoport
2024-09-11T10:22:20Z

On Mon, Sep 09, 2024 at 10:49:40AM -0400, Steven Rostedt wrote:
> On Mon, 9 Sep 2024 17:34:48 +0300
> Mike Rapoport <rppt@kernel.org> wrote:
>
> > > This is insane, just force BUILDTIME_MCOUNT_SORT
> >
> > The comment in ftrace.c says "... while mcount loc in modules can not be
> > sorted at build time"
> >
> > I don't know enough about objtool, but I'd presume it's because the sorting
> > should happen after relocations, no?
> >
>
> IIRC, the sorting at build time uses scripts/sorttable.c, which from what I
> can tell, only gets called on vmlinux.

Regardless of the tool, the sorting should be done after relocation, no?

But isn't mcount loc is in data section? Then there should be no problem
just drop this patch

> -- Steve

--
Sincerely yours,
Mike.