From: Nathan Chancellor <nathan@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Martin KaFai Lau <martin.lau@linux.dev>,
bpf@vger.kernel.org, linux-arch@vger.kernel.org,
Andrii Nakryiko <andrii@kernel.org>,
linux-kernel@vger.kernel.org, Nicolas Schier <nicolas@fjasle.eu>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 1/3] btf: remove redundant CONFIG_BPF test in scripts/link-vmlinux.sh
Date: Wed, 11 Sep 2024 14:02:41 -0700 [thread overview]
Message-ID: <20240911210241.GA2305132@thelio-3990X> (raw)
In-Reply-To: <20240911110401.598586-1-masahiroy@kernel.org>
On Wed, Sep 11, 2024 at 08:03:56PM +0900, Masahiro Yamada wrote:
> CONFIG_DEBUG_INFO_BTF depends on CONFIG_BPF_SYSCALL, which in turn
> selects CONFIG_BPF.
>
> When CONFIG_DEBUG_INFO_BTF=y, CONFIG_BPF=y is always met.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
>
> scripts/link-vmlinux.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index bd196944e350..cfffc41e20ed 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -288,7 +288,7 @@ strip_debug=
> vmlinux_link vmlinux
>
> # fill in BTF IDs
> -if is_enabled CONFIG_DEBUG_INFO_BTF && is_enabled CONFIG_BPF; then
> +if is_enabled CONFIG_DEBUG_INFO_BTF; then
> info BTFIDS vmlinux
> ${RESOLVE_BTFIDS} vmlinux
> fi
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-09-11 21:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 11:03 [PATCH 1/3] btf: remove redundant CONFIG_BPF test in scripts/link-vmlinux.sh Masahiro Yamada
2024-09-11 11:03 ` [PATCH 2/3] btf: move pahole check in scripts/link-vmlinux.sh to lib/Kconfig.debug Masahiro Yamada
2024-09-11 17:25 ` Alan Maguire
2024-09-12 0:45 ` Masahiro Yamada
2024-09-11 21:07 ` Andrii Nakryiko
2024-09-11 21:08 ` Nathan Chancellor
2024-09-11 11:03 ` [PATCH 3/3] btf: require pahole 1.21+ for DEBUG_INFO_BTF with default DWARF version Masahiro Yamada
2024-09-11 21:08 ` Andrii Nakryiko
2024-09-11 21:10 ` Nathan Chancellor
2024-09-11 21:02 ` Nathan Chancellor [this message]
2024-09-11 21:05 ` [PATCH 1/3] btf: remove redundant CONFIG_BPF test in scripts/link-vmlinux.sh Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911210241.GA2305132@thelio-3990X \
--to=nathan@kernel.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=masahiroy@kernel.org \
--cc=nicolas@fjasle.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox