From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BC8E192B73; Thu, 12 Sep 2024 23:57:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726185482; cv=none; b=GA2kAh3Qg+TVXTXhRw3VdWRdmeFso2XFDnBjPKK/VeneTWssryTjlkv2qfK77qP0y5yJmEoHLxbq81bzTlvKzq3z1r+L5gIv5wdgkvaWi1suzuNajvxdGKAv0lc8Ebjk3yDbMmF+tl9dy6NRO8UJJPP7FhlCZj1diJpIih3Keok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726185482; c=relaxed/simple; bh=wzS7NWwfBAD5/gcp4BhtXmqxKlcXVYKgAbXgTM+fYVU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hya7tj7pSqHS0UV0g8fqfQE09rrC7YdBLeSLG79sskBxbc0YUQbWyfMQ+gbaTIQ2syr2hiFQdgfm2+APA7CqQkl+0nKEZhNpMuYJrUwcIJn1oQsUCYfS3dFuGbx+3lUtCHFlhhgyFrl2aivqwB8W2LuYUJfyko6MnaeZ+gKY9hI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=BQqPl3vC; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="BQqPl3vC" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+uTreIPhEeUbUdLeE/WmAwK4uMRYmdo43yIVGufOawY=; b=BQqPl3vCxsPbn5xJyC4ewYDMWY UUlqQJeLirOQeSSvN8xlc2BHt6UrJxH+JI+J0PCyfjbMJDphVsunfRYEaBLm9xo3O8a/yawoP6YP5 0lPM0mxm8nQh59QZpL3abOfTJqYvQPVxaAFitNeQtugK2TrF5HpcZQZ9E6YNyH8po+tjpHHQe8h6U p1bKYIIJ40UmGfsusWIIybH2RHmI6GpK67LtvVOh3+YWbNcQn8u9aLnhVoTRwgOg2AIyZdHO9aeQ7 LeewfnqdhmN/5+oALfKV+SG0fkF5qL6kRMtbxRKntCcqfLbophqIwVTVVfojIM+DS9U4GcycqCOdh GO5Ih51A==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98 #2 (Red Hat Linux)) id 1sothE-0000000BoCw-3fim; Thu, 12 Sep 2024 23:57:56 +0000 Date: Fri, 13 Sep 2024 00:57:56 +0100 From: Al Viro To: Andrii Nakryiko Cc: viro@kernel.org, brauner@kernel.org, bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org, linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org, Andrii Nakryiko Subject: Re: [PATCH bpf-next 0/8] BPF follow ups to struct fd refactorings Message-ID: <20240912235756.GN1049718@ZenIV> References: <20240813230300.915127-1-andrii@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro On Tue, Aug 27, 2024 at 03:55:28PM -0700, Andrii Nakryiko wrote: > > They were also merged into bpf-next/for-next so they can get early testing in > > linux-next. Umm... I see that stuff in bpf-next/struct_fd, but not in your for-next. > Can you guys please take a look and let us know if this looks sane and > fine to you? I kept Al's patches mostly intact (see my notes in the > cover letter above), and patch #3 does the refactoring I proposed > earlier, keeping explicit fdput() temporarily, until Al's > __bpf_map_get() refactoring which allows and nice and simple CLASS(fd) > conversion. > > I think we end up at exactly what the end goal of the original series > is: using CLASS(fd, ...) throughout with all the benefits. Looks sane.