From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org
Cc: netdev@vger.kernel.org, magnus.karlsson@intel.com,
bjorn@kernel.org, maciej.fijalkowski@intel.com, vadfed@meta.com
Subject: [PATCH v2 bpf-next 0/6] xsk: struct diet and cleanups
Date: Mon, 7 Oct 2024 14:24:52 +0200 [thread overview]
Message-ID: <20241007122458.282590-1-maciej.fijalkowski@intel.com> (raw)
Hi all,
this modest work brings back size of xdp_buff_xsk back to two cache
lines which in turn improves performance. Interestingly I was able to
observe on ice with HW rings sized to 512 around 12% better performance
when running xdpsock in l2fwd scenario. First three patches are behind
this. Other setups were not that impressive, I believe results may vary
based on the underlying CPU. Bottom line is that shrinking this struct
takes off a bit of work from CPU's shoulders.
Other three patches are rather cleanups.
Thanks,
Maciej
v1->v2:
* fix build issues on patch 1 (Daniel, CI)
* be smarter about xsk_buff_pool layout in patch 4 (Vadim)
Maciej Fijalkowski (6):
xsk: get rid of xdp_buff_xsk::xskb_list_node
xsk: s/free_list_node/list_node
xsk: get rid of xdp_buff_xsk::orig_addr
xsk: carry a copy of xdp_zc_max_segs within xsk_buff_pool
xsk: wrap duplicated code to function
xsk: use xsk_buff_pool directly for cq functions
include/net/xdp_sock_drv.h | 14 +++++-----
include/net/xsk_buff_pool.h | 23 +++++++++-------
net/xdp/xsk.c | 38 +++++++++++++-------------
net/xdp/xsk_buff_pool.c | 54 ++++++++++++++++++++-----------------
net/xdp/xsk_queue.h | 2 +-
5 files changed, 69 insertions(+), 62 deletions(-)
--
2.34.1
next reply other threads:[~2024-10-07 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 12:24 Maciej Fijalkowski [this message]
2024-10-07 12:24 ` [PATCH v2 bpf-next 1/6] xsk: get rid of xdp_buff_xsk::xskb_list_node Maciej Fijalkowski
2024-10-07 12:24 ` [PATCH v2 bpf-next 2/6] xsk: s/free_list_node/list_node Maciej Fijalkowski
2024-10-07 12:24 ` [PATCH v2 bpf-next 3/6] xsk: get rid of xdp_buff_xsk::orig_addr Maciej Fijalkowski
2024-10-07 12:24 ` [PATCH v2 bpf-next 4/6] xsk: carry a copy of xdp_zc_max_segs within xsk_buff_pool Maciej Fijalkowski
2024-10-07 12:24 ` [PATCH v2 bpf-next 5/6] xsk: wrap duplicated code to function Maciej Fijalkowski
2024-10-07 12:24 ` [PATCH v2 bpf-next 6/6] xsk: use xsk_buff_pool directly for cq functions Maciej Fijalkowski
2024-10-08 10:31 ` [PATCH v2 bpf-next 0/6] xsk: struct diet and cleanups Magnus Karlsson
2024-10-14 15:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007122458.282590-1-maciej.fijalkowski@intel.com \
--to=maciej.fijalkowski@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=vadfed@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox