From: kernel test robot <lkp@intel.com>
To: Andrea Righi <andrea.righi@linux.dev>, Tejun Heo <tj@kernel.org>,
David Vernet <void@manifault.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Cc: oe-kbuild-all@lists.linux.dev,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v4] sched_ext: Trigger ops.update_idle() from pick_task_idle()
Date: Wed, 16 Oct 2024 20:26:07 +0800 [thread overview]
Message-ID: <202410161955.CsmEsAy8-lkp@intel.com> (raw)
In-Reply-To: <20241015111539.12136-1-andrea.righi@linux.dev>
Hi Andrea,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on linus/master v6.12-rc3 next-20241016]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andrea-Righi/sched_ext-Trigger-ops-update_idle-from-pick_task_idle/20241015-191701
base: tip/sched/core
patch link: https://lore.kernel.org/r/20241015111539.12136-1-andrea.righi%40linux.dev
patch subject: [PATCH v4] sched_ext: Trigger ops.update_idle() from pick_task_idle()
config: x86_64-randconfig-122-20241016 (https://download.01.org/0day-ci/archive/20241016/202410161955.CsmEsAy8-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241016/202410161955.CsmEsAy8-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410161955.CsmEsAy8-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
kernel/sched/build_policy.c: note: in included file:
>> kernel/sched/idle.c:481:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/idle.c:481:22: sparse: struct task_struct [noderef] __rcu *
kernel/sched/idle.c:481:22: sparse: struct task_struct *
kernel/sched/build_policy.c: note: in included file:
kernel/sched/rt.c:991:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct task_struct *curr @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/rt.c:991:38: sparse: expected struct task_struct *curr
kernel/sched/rt.c:991:38: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/rt.c:1529:31: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct task_struct *p @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/rt.c:1529:31: sparse: expected struct task_struct *p
kernel/sched/rt.c:1529:31: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/build_policy.c: note: in included file:
kernel/sched/deadline.c:2341:42: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct sched_dl_entity const *b @@ got struct sched_dl_entity [noderef] __rcu * @@
kernel/sched/deadline.c:2341:42: sparse: expected struct sched_dl_entity const *b
kernel/sched/deadline.c:2341:42: sparse: got struct sched_dl_entity [noderef] __rcu *
kernel/sched/deadline.c:1242:39: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *p @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/deadline.c:1242:39: sparse: expected struct task_struct *p
kernel/sched/deadline.c:1242:39: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/deadline.c:1242:85: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct sched_dl_entity const *b @@ got struct sched_dl_entity [noderef] __rcu * @@
kernel/sched/deadline.c:1242:85: sparse: expected struct sched_dl_entity const *b
kernel/sched/deadline.c:1242:85: sparse: got struct sched_dl_entity [noderef] __rcu *
kernel/sched/deadline.c:1342:23: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *p @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/deadline.c:1342:23: sparse: expected struct task_struct *p
kernel/sched/deadline.c:1342:23: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/deadline.c:1651:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *p @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/deadline.c:1651:31: sparse: expected struct task_struct *p
kernel/sched/deadline.c:1651:31: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/deadline.c:1651:70: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct sched_dl_entity const *b @@ got struct sched_dl_entity [noderef] __rcu * @@
kernel/sched/deadline.c:1651:70: sparse: expected struct sched_dl_entity const *b
kernel/sched/deadline.c:1651:70: sparse: got struct sched_dl_entity [noderef] __rcu *
kernel/sched/deadline.c:1739:38: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct task_struct *curr @@ got struct task_struct [noderef] __rcu *curr @@
kernel/sched/deadline.c:1739:38: sparse: expected struct task_struct *curr
kernel/sched/deadline.c:1739:38: sparse: got struct task_struct [noderef] __rcu *curr
kernel/sched/deadline.c:3054:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/deadline.c:3054:22: sparse: struct task_struct [noderef] __rcu *
kernel/sched/deadline.c:3054:22: sparse: struct task_struct *
kernel/sched/build_policy.c: note: in included file:
kernel/sched/syscalls.c:206:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/syscalls.c:206:22: sparse: struct task_struct [noderef] __rcu *
kernel/sched/syscalls.c:206:22: sparse: struct task_struct *
kernel/sched/build_policy.c: note: in included file (through include/linux/smp.h, include/linux/sched/clock.h):
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
kernel/sched/build_policy.c: note: in included file:
kernel/sched/sched.h:2265:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2265:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2265:25: sparse: struct task_struct *
kernel/sched/sched.h:2265:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2265:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2265:25: sparse: struct task_struct *
kernel/sched/sched.h:2265:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2265:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2265:25: sparse: struct task_struct *
kernel/sched/sched.h:2265:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2265:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2265:25: sparse: struct task_struct *
kernel/sched/sched.h:2265:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2265:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2265:25: sparse: struct task_struct *
kernel/sched/sched.h:2451:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2451:9: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2451:9: sparse: struct task_struct *
kernel/sched/sched.h:2265:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2265:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2265:25: sparse: struct task_struct *
kernel/sched/sched.h:2451:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2451:9: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2451:9: sparse: struct task_struct *
kernel/sched/build_policy.c: note: in included file:
kernel/sched/syscalls.c:1331:6: sparse: sparse: context imbalance in 'sched_getaffinity' - different lock contexts for basic block
kernel/sched/build_policy.c: note: in included file:
kernel/sched/sched.h:2265:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/sched/sched.h:2265:25: sparse: struct task_struct [noderef] __rcu *
kernel/sched/sched.h:2265:25: sparse: struct task_struct *
vim +481 kernel/sched/idle.c
466
467 struct task_struct *pick_task_idle(struct rq *rq)
468 {
469 /*
470 * When switching from a non-idle to the idle class, .set_next_task()
471 * is called only once during the transition.
472 *
473 * However, the CPU may remain active for multiple rounds running the
474 * idle task (e.g., by calling scx_bpf_kick_cpu() from the
475 * ops.update_idle() callback).
476 *
477 * In such cases, we need to keep updating the scx idle state to
478 * properly re-trigger the ops.update_idle() callback and ensure
479 * correct handling of scx idle state transitions.
480 */
> 481 if (rq->curr == rq->idle)
482 scx_update_idle(rq, true);
483 return rq->idle;
484 }
485
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2024-10-16 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 11:15 [PATCH v4] sched_ext: Trigger ops.update_idle() from pick_task_idle() Andrea Righi
2024-10-15 14:41 ` Tejun Heo
2024-10-15 15:31 ` Andrea Righi
2024-10-15 22:12 ` Andrea Righi
2024-10-16 12:26 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202410161955.CsmEsAy8-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrea.righi@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox